Re: [PATCH nf-next 3/6] netfilter: nf_tables: disable old tracing if listener is present

[Patrick McHardy <kaber@trash.net>]

On 25.11, Pablo Neira Ayuso wrote:
> On Wed, Nov 25, 2015 at 03:06:40PM +0000, Patrick McHardy wrote:
> > @@ -698,6 +703,10 @@ const struct proto_desc proto_arp = {
> >  		[ARPHDR_HLN]		= ARPHDR_FIELD("hlen", ar_hln),
> >  		[ARPHDR_PLN]		= ARPHDR_FIELD("plen", ar_pln),
> >  		[ARPHDR_OP]		= ARPHDR_TYPE("operation", &arpop_type, ar_op),
> > +		[ARPHDR_SHA]		= PROTO_HDR_TEMPLATE("sha", &etheraddr_type, BYTEORDER_BIG_ENDIAN, 8 * BITS_PER_BYTE, 6 * BITS_PER_BYTE),
> > +		[ARPHDR_SPA]		= PROTO_HDR_TEMPLATE("sip", &ipaddr_type, BYTEORDER_BIG_ENDIAN, 14 * BITS_PER_BYTE, 4 * BITS_PER_BYTE),
> > +		[ARPHDR_THA]		= PROTO_HDR_TEMPLATE("tha", &etheraddr_type, BYTEORDER_BIG_ENDIAN, 18 * BITS_PER_BYTE, 6 * BITS_PER_BYTE),
> > +		[ARPHDR_TPA]		= PROTO_HDR_TEMPLATE("tip", &ipaddr_type, BYTEORDER_BIG_ENDIAN, 24 * BITS_PER_BYTE, 4 * BITS_PER_BYTE),
> >  	},
> >  };
> >  
> 
> Could you also push this chunk into the repository?
> 
> I have a similar patch here for this. Given that we only support ARP
> for IPv4, we don't have to worry about the variable length offset in
> this case.

Sure. So far I've only added the decoding part, so the parser has no way
to support this yet. The symbol names are quite ugly, any ideas for nicer
ones?

Cheers,
Patrick