From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org, Valdis.Kletnieks@vt.edu
Subject: Re: [PATCH nf-next] netfilter: ipv6: nf_defrag: fix NULL deref panic
Date: Wed, 9 Dec 2015 14:27:02 +0100 [thread overview]
Message-ID: <20151209132702.GA29572@salvia> (raw)
In-Reply-To: <1449614119-5584-1-git-send-email-fw@strlen.de>
On Tue, Dec 08, 2015 at 11:35:19PM +0100, Florian Westphal wrote:
> Valdis reports NULL deref in nf_ct_frag6_gather.
> Problem is bogus use of skb_queue_walk() -- we miss first skb in the list
> since we start with head->next instead of head.
>
> In case the element we're looking for was head->next we won't find
> a result and then trip over NULL iter.
>
> (defrag uses plain NULL-terminated list rather than one terminated by
> head-of-list-pointer, which is what skb_queue_walk expects).
Applied, thanks Florian.
prev parent reply other threads:[~2015-12-09 13:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 22:35 [PATCH nf-next] netfilter: ipv6: nf_defrag: fix NULL deref panic Florian Westphal
2015-12-09 13:27 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151209132702.GA29572@salvia \
--to=pablo@netfilter.org \
--cc=Valdis.Kletnieks@vt.edu \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).