From: Christoph Hellwig <hch@infradead.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>, Geliang Tang <geliangtang@163.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Jan Kara <jack@suse.cz>, Josef Bacik <jbacik@fb.com>,
Josh Triplett <josh@joshtriplett.org>,
Seth Jennings <sjenning@redhat.com>,
Jiri Kosina <jikos@kernel.org>, Vojtech Pavlik <vojtech@suse.com>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Patrick McHardy <kaber@trash.net>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
"David S. Miller" <davem@davemloft.net>,
live-patching@vger.kernel.org, netfilter-devel@vger.kernel.org,
coreteam@netfilter.org, netdev@vger.kernel.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] list: introduce list_is_first()
Date: Thu, 10 Dec 2015 07:35:40 -0800 [thread overview]
Message-ID: <20151210153540.GA27533@infradead.org> (raw)
In-Reply-To: <20151210152357.GG29872@treble.redhat.com>
On Thu, Dec 10, 2015 at 09:23:57AM -0600, Josh Poimboeuf wrote:
> Personally I would disagree. Something like:
>
> if (list_is_first(&rq->queuelist, &nd->queue))
>
> is much more readable to me than:
>
> if (rq->queuelist.prev == &nd->queue)
>
> The first one takes no effort for me -- it's almost English. While the
> second one takes me a few seconds (and some precious brain cycles) to
> decipher.
>
> Maybe whether it's readable depends on how many years you've been
> looking at the pattern. But IMHO we shouldn't make "having x # of years
> staring at kernel code" a prerequisite for being able to read kernel
> code.
I think understanding the list.h semantics is a requirement for writing
(or reading) non-trivial kernel code.
prev parent reply other threads:[~2015-12-10 15:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-10 14:17 [PATCH 1/4] list: introduce list_is_first() Geliang Tang
2015-12-10 14:17 ` [PATCH 2/4] livepatch: use list_is_first() Geliang Tang
2015-12-10 14:17 ` [PATCH 3/4] netfilter: ipset: " Geliang Tang
2015-12-10 14:20 ` [PATCH 4/4] elevator: use list_is_{first,last} Geliang Tang
2015-12-10 15:10 ` [PATCH 1/4] list: introduce list_is_first() Jens Axboe
2015-12-10 15:23 ` Josh Poimboeuf
2015-12-10 15:35 ` Jens Axboe
2015-12-10 16:47 ` Jiri Kosina
2015-12-10 15:35 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151210153540.GA27533@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=geliangtang@163.com \
--cc=jack@suse.cz \
--cc=jbacik@fb.com \
--cc=jikos@kernel.org \
--cc=josh@joshtriplett.org \
--cc=jpoimboe@redhat.com \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=sjenning@redhat.com \
--cc=vojtech@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).