From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netfilter-devel@vger.kernel.org
Cc: arturo.borrero.glez@gmail.com, ben@decadent.org.uk
Subject: Re: [PATCH nf,v2] netfilter: nf_tables: release objects on netns destruction
Date: Sun, 13 Dec 2015 22:42:20 +0100 [thread overview]
Message-ID: <20151213214220.GA1764@salvia> (raw)
In-Reply-To: <1449690931-1617-1-git-send-email-pablo@netfilter.org>
On Wed, Dec 09, 2015 at 08:55:31PM +0100, Pablo Neira Ayuso wrote:
> We have to release the existing objects on netns removal otherwise we
> leak them. Chains are unregistered in first place to make sure no
> packets are walking on our rules and sets anymore.
I have detected a problem in this patch.
The netns_exit path from every family is removing the afinfo object
before this iteration here, so this is not working in case family
netns exit callbacks are called before the ones from the core.
I'm going to toss it, will send a new version.
prev parent reply other threads:[~2015-12-13 21:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 19:55 [PATCH nf,v2] netfilter: nf_tables: release objects on netns destruction Pablo Neira Ayuso
2015-12-11 8:33 ` Arturo Borrero Gonzalez
2015-12-13 21:42 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151213214220.GA1764@salvia \
--to=pablo@netfilter.org \
--cc=arturo.borrero.glez@gmail.com \
--cc=ben@decadent.org.uk \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).