From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Tom Herbert <tom@herbertland.com>,
netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] ila: add NETFILTER dependency
Date: Fri, 18 Dec 2015 19:09:31 +0100 [thread overview]
Message-ID: <20151218180931.GC29573@breakpoint.cc> (raw)
In-Reply-To: <20151218172606.GB1299@salvia>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> On Fri, Dec 18, 2015 at 03:37:37PM +0100, Arnd Bergmann wrote:
> > The recently added generic ILA translation facility fails to
> > build when CONFIG_NETFILTER is disabled:
> >
> > net/ipv6/ila/ila_xlat.c:229:20: warning: 'struct nf_hook_state' declared inside parameter list
> > net/ipv6/ila/ila_xlat.c:235:27: error: array type has incomplete element type 'struct nf_hook_ops'
> > static struct nf_hook_ops ila_nf_hook_ops[] __read_mostly = {
> >
> > This adds an explicit Kconfig dependency to avoid that case.
>
> I'm afraid this extra Kconfig dependency that Arnd adds to fix this is
> a symptom that there is something that doesn't belong there.
>
> I overlook this new hook on priority -1, how does this integrate into
> our infrastructure?
Looks problematic since address changes post ipv6 dnat translations,
its certainly unexpected for nft since we have magic address mangling
after -2 and 0 priroized tables...
However ... how is ILA supposed to work?
ila_xlat_outgoing has no callers, so it appears we only do this
stateless nat on ingress...?
next prev parent reply other threads:[~2015-12-18 18:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-18 14:37 [PATCH] ila: add NETFILTER dependency Arnd Bergmann
2015-12-18 17:26 ` Pablo Neira Ayuso
2015-12-18 18:09 ` Florian Westphal [this message]
2015-12-18 20:37 ` Pablo Neira Ayuso
2015-12-18 19:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151218180931.GC29573@breakpoint.cc \
--to=fw@strlen.de \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).