netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
Cc: Shivani Bhardwaj <shivanib134@gmail.com>,
	Netfilter Development Mailing list
	<netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH] extensions: libxt_NFLOG: Add translation to nft
Date: Tue, 22 Dec 2015 18:01:51 +0100	[thread overview]
Message-ID: <20151222170151.GA20841@salvia> (raw)
In-Reply-To: <CAOkSjBiJ+wWWyt+4ewjEJyMN79C6Navd19Av6n6LVo0tfyd-Ow@mail.gmail.com>

On Tue, Dec 22, 2015 at 01:47:57PM +0100, Arturo Borrero Gonzalez wrote:
> On 21 December 2015 at 18:35, Shivani Bhardwaj <shivanib134@gmail.com> wrote:
> >
> > +static void nflog_print_xlate(const struct xt_nflog_info *info,
> > +                             char *prefix, struct xt_buf *buf)
> > +{
> > +       if (info->prefix[0] != '\0')
> > +               xt_buf_add(buf, "%slog prefix \\\"%s\\\" ",
> > +                          prefix, info->prefix);
> > +       if (info->group)
> > +               xt_buf_add(buf, "%slog group %u ", prefix, info->group);
> 
> if info->group is not set, you should probably default to 0, since
> this group info is mandatory in nftables to consider this logging the
> same type of NFLOG (ie, use nfnetlink_log).
> 
> For reference, see:
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/net/netfilter/nft_log.c#n67

Thanks Arturo.

Please Shivani, address Arturo's feedback and send me an incremental
patch to fix this.

  reply	other threads:[~2015-12-22 17:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-21 17:35 [PATCH] extensions: libxt_NFLOG: Add translation to nft Shivani Bhardwaj
2015-12-22 12:40 ` Arturo Borrero Gonzalez
2015-12-22 12:47 ` Arturo Borrero Gonzalez
2015-12-22 17:01   ` Pablo Neira Ayuso [this message]
2015-12-22 16:43 ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151222170151.GA20841@salvia \
    --to=pablo@netfilter.org \
    --cc=arturo.borrero.glez@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=shivanib134@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).