From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Shivani Bhardwaj <shivanib134@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] extensions: libipt_REJECT: Add translation to nft
Date: Mon, 28 Dec 2015 13:17:29 +0100 [thread overview]
Message-ID: <20151228121729.GA19188@salvia> (raw)
In-Reply-To: <20151227044248.GA5043@gmail.com>
On Sun, Dec 27, 2015 at 10:12:48AM +0530, Shivani Bhardwaj wrote:
> Add translation for target REJECT to nftables.
Applied, thanks.
> +static int REJECT_xlate(const struct xt_entry_target *target,
> + struct xt_buf *buf, int numeric)
> +{
> + const struct ipt_reject_info *reject
> + = (const struct ipt_reject_info *)target->data;
BTW, always keep the operand on the original line that you're
breaking, ie.
const struct ipt_reject_info *reject =
(const struct ipt_reject_info *)target->data;
This also applies to things like:
if (a != 10 &&
b != 20 &&
c != 30)
Please, follow up with a translation for libip6t_REJECT. Thanks.
prev parent reply other threads:[~2015-12-28 12:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-27 4:42 [PATCH] extensions: libipt_REJECT: Add translation to nft Shivani Bhardwaj
2015-12-28 12:17 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151228121729.GA19188@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=shivanib134@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox