netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] iptables: add xtables-config-parser.h to BUILT_SOURCES
@ 2015-12-30 17:51 Gustavo Zacarias
  2016-01-03 22:14 ` Pablo Neira Ayuso
  0 siblings, 1 reply; 2+ messages in thread
From: Gustavo Zacarias @ 2015-12-30 17:51 UTC (permalink / raw)
  To: netfilter-devel; +Cc: Gustavo Zacarias

Otherwise other sources that use it might be built before it's ready leading
to build failure, for example by iptables/nft.c

Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
 iptables/Makefile.am | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/iptables/Makefile.am b/iptables/Makefile.am
index 3c0faa5..c3eb8a8 100644
--- a/iptables/Makefile.am
+++ b/iptables/Makefile.am
@@ -4,6 +4,8 @@ AM_CFLAGS        = ${regular_CFLAGS}
 AM_CPPFLAGS      = ${regular_CPPFLAGS} -I${top_builddir}/include -I${top_srcdir}/include ${kinclude_CPPFLAGS} ${libmnl_CFLAGS} ${libnftnl_CFLAGS} ${libnetfilter_conntrack_CFLAGS}
 AM_YFLAGS = -d
 
+BUILT_SOURCES =
+
 xtables_multi_SOURCES  = xtables-multi.c iptables-xml.c
 xtables_multi_CFLAGS   = ${AM_CFLAGS}
 xtables_multi_LDADD    = ../extensions/libext.a
@@ -27,6 +29,7 @@ xtables_multi_LDADD   += ../libxtables/libxtables.la -lm
 
 # nftables compatibility layer
 if ENABLE_NFTABLES
+BUILT_SOURCES += xtables-config-parser.h
 xtables_compat_multi_SOURCES  = xtables-compat-multi.c iptables-xml.c
 xtables_compat_multi_CFLAGS   = ${AM_CFLAGS}
 xtables_compat_multi_LDADD    = ../extensions/libext.a ../extensions/libext_ebt.a
-- 
2.4.10


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] iptables: add xtables-config-parser.h to BUILT_SOURCES
  2015-12-30 17:51 [PATCH] iptables: add xtables-config-parser.h to BUILT_SOURCES Gustavo Zacarias
@ 2016-01-03 22:14 ` Pablo Neira Ayuso
  0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2016-01-03 22:14 UTC (permalink / raw)
  To: Gustavo Zacarias; +Cc: netfilter-devel

On Wed, Dec 30, 2015 at 02:51:30PM -0300, Gustavo Zacarias wrote:
> Otherwise other sources that use it might be built before it's ready leading
> to build failure, for example by iptables/nft.c

Applied, thanks Gustavo.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-01-03 22:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-30 17:51 [PATCH] iptables: add xtables-config-parser.h to BUILT_SOURCES Gustavo Zacarias
2016-01-03 22:14 ` Pablo Neira Ayuso

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).