From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Feng Gao <gfree.wind@outlook.com>
Cc: netfilter-devel@vger.kernel.org, fgao@ikuai8.com
Subject: Re: 答复: [PATCH 3/3 nf-next] netfilter: nf_ct_helper: Add nf_conntrack_helpers_register()
Date: Mon, 4 Jan 2016 17:46:56 +0100 [thread overview]
Message-ID: <20160104164656.GA2135@salvia> (raw)
In-Reply-To: <20160104161550.GB1303@salvia>
On Mon, Jan 04, 2016 at 05:15:50PM +0100, Pablo Neira Ayuso wrote:
> On Mon, Jan 04, 2016 at 10:14:40PM +0800, Feng Gao wrote:
> > Hi Pablo,
> >
> > I received the warning notification.
> > But I just checked the patch file, and find I already initialized the "err"
> > in the nf_conntrack_helpers_register.
> >
> > http://www.spinics.net/lists/netfilter-devel/msg39270.html
>
> Will fix this here, no problem.
BTW, it would be good if you can send us a follow up patch on top of
this series to switch from the bidimensional to unidimensional arrays
to store the helper structures, so we can get rid of the &array[0][0]
thing.
next prev parent reply other threads:[~2016-01-04 16:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-04 11:48 [PATCH 1/3 nf-next] netfilter: nf_ct_helper: define pr_fmt() Pablo Neira Ayuso
2016-01-04 11:48 ` [PATCH 2/3 nf-next] netfilter: nf_ct_helper: Add new function nf_ct_helper_init() Pablo Neira Ayuso
2016-01-04 11:48 ` [PATCH 3/3 nf-next] netfilter: nf_ct_helper: Add nf_conntrack_helpers_register() Pablo Neira Ayuso
2016-01-04 11:58 ` kbuild test robot
[not found] ` <BAY403-EAS25258E748DF4B612DF8D4AF95F20@phx.gbl>
2016-01-04 16:15 ` 答复: " Pablo Neira Ayuso
2016-01-04 16:46 ` Pablo Neira Ayuso [this message]
[not found] ` <BAY403-EAS3732A77CAF9E1DCE79ED89395F20@phx.gbl>
[not found] ` <BAY403-EAS181F9CE879F779A8E160FD195F50@phx.gbl>
[not found] ` <BAY403-EAS167CF4DCA9B031F6AEFDF7F95F60@phx.gbl>
2016-01-08 12:22 ` 答复: " Pablo Neira Ayuso
[not found] ` <BAY403-EAS1672CCA8B36E7E4F7EC720E95F70@phx.gbl>
2016-01-09 12:17 ` 答复: " Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160104164656.GA2135@salvia \
--to=pablo@netfilter.org \
--cc=fgao@ikuai8.com \
--cc=gfree.wind@outlook.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).