From: Florian Westphal <fw@strlen.de>
To: "Carlos Falgueras García" <carlosfg@riseup.net>
Cc: netfilter-devel@vger.kernel.org, pablo@netfilter.org, kaber@trash.net
Subject: Re: [PATCH 3/4 v2] libnftnl: set: Implement new buffer of TLV objects.
Date: Tue, 5 Jan 2016 14:28:47 +0100 [thread overview]
Message-ID: <20160105132847.GA24311@breakpoint.cc> (raw)
In-Reply-To: <1451999013-4313-2-git-send-email-carlosfg@riseup.net>
Carlos Falgueras García <carlosfg@riseup.net> wrote:
> These functions allow create a buffer (nftnl_attrbuf) of TLV objects
> (nftnl_attr). It is inspired in libmnl/src/attr.c.
It would be nice to get a summary on how this going to be used.
At this time I don't understand why nftnl needs this api,
the kernel doesn't enforce any format on this data (good), so we cannot
rely on it having any specific format when reading arbitrary userdata
(added by someone else).
> +EXPORT_SYMBOL_ALIAS(nftnl_attrbuf_alloc, nft_attrbuf_alloc);
This should be plain EXPORT_SYMBOL everywhere, ALIAS is just
for backwards compat.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-01-05 13:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 13:03 [PATCH 1/4 v2] nf: netfilter: nf_tables_api: Add new attributes into nft_set to store user data Carlos Falgueras García
2016-01-05 13:03 ` [PATCH 3/4 v2] libnftnl: set: Implement new buffer of TLV objects Carlos Falgueras García
2016-01-05 13:28 ` Florian Westphal [this message]
2016-01-08 13:41 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160105132847.GA24311@breakpoint.cc \
--to=fw@strlen.de \
--cc=carlosfg@riseup.net \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).