From: Stephen Hemminger <shemming@brocade.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>,
Mikko Rapeli <mikko.rapeli@iki.fi>
Cc: <netdev@vger.kernel.org>, <netfilter-devel@vger.kernel.org>
Subject: header conflict introduced by change to netfilter_ipv4/ip_tables.h
Date: Wed, 6 Jan 2016 09:20:07 -0800 [thread overview]
Message-ID: <20160106092007.1c5a0c75@xeon-e3> (raw)
This commit breaks compilation of iproute2 with net-next.
commit 1ffad83dffd675cd742286ae82dca7d746cb0da8
Author: Mikko Rapeli <mikko.rapeli@iki.fi>
Date: Thu Oct 15 07:56:30 2015 +0200
netfilter: fix include files for compilation
Add missing header dependencies and other small changes so that each file
compiles alone in userspace.
Signed-off-by: Mikko Rapeli <mikko.rapeli@iki.fi>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
For iproute2, a copy of kernel headers (from make install_headers) is used.
After this change. the build of x_tables.c fails because IFNAMSIZ is already
defined in net/if.h
gcc -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wold-style-definition -Wformat=2 -O2 -I../include -DRESOLVE_HOSTNAMES -DLIBDIR=\"/usr/lib\" -DCONFDIR=\"/etc/iproute2\" -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DHAVE_SETNS -DHAVE_ELF -DCONFIG_GACT -DCONFIG_GACT_PROB -DIPT_LIB_DIR=\"/lib/xtables\" -DYY_NO_INPUT -Wl,-export-dynamic -shared -fpic -o q_atm.so q_atm.c -latm
gcc -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wold-style-definition -Wformat=2 -O2 -I../include -DRESOLVE_HOSTNAMES -DLIBDIR=\"/usr/lib\" -DCONFDIR=\"/etc/iproute2\" -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DHAVE_SETNS -DHAVE_ELF -DCONFIG_GACT -DCONFIG_GACT_PROB -DIPT_LIB_DIR=\"/lib/xtables\" -DYY_NO_INPUT -Wl,-export-dynamic -shared -fpic -o m_xt.so m_xt.c $(pkg-config xtables --cflags --libs)
In file included from ../include/linux/netfilter_ipv4/ip_tables.h:20:0,
from m_xt.c:20:
../include/linux/if.h:26:0: warning: "IFNAMSIZ" redefined
#define IFNAMSIZ 16
^
In file included from m_xt.c:17:0:
/usr/include/net/if.h:129:0: note: this is the location of the previous definition
# define IFNAMSIZ IF_NAMESIZE
^
../include/linux/if.h:71:2: error: redeclaration of enumerator ‘IFF_UP’
IFF_UP = 1<<0, /* sysfs */
^
/usr/include/net/if.h:44:5: note: previous definition of ‘IFF_UP’ was here
IFF_UP = 0x1, /* Interface is up. */
^
../include/linux/if.h:72:2: error: redeclaration of enumerator ‘IFF_BROADCAST’
IFF_BROADCAST = 1<<1, /* __volatile__ */
^
/usr/include/net/if.h:46:5: note: previous definition of ‘IFF_BROADCAST’ was here
IFF_BROADCAST = 0x2, /* Broadcast address valid. */
^
../include/linux/if.h:73:2: error: redeclaration of enumerator ‘IFF_DEBUG’
IFF_DEBUG = 1<<2, /* sysfs */
next reply other threads:[~2016-01-06 17:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-06 17:20 Stephen Hemminger [this message]
2016-01-07 7:29 ` header conflict introduced by change to netfilter_ipv4/ip_tables.h Mikko Rapeli
[not found] ` <88a455d4b6dc4d4398553e6529d7b94a@HQ1WP-EXMB11.corp.brocade.com>
2016-01-07 18:30 ` Stephen Hemminger
2016-01-07 19:15 ` Mikko Rapeli
2016-02-04 7:13 ` Josh Boyer
[not found] ` <CA+5PVA4P2avVr+m=ittQUyBou9kT2nbK0-Jeo+3coAFyQXTT_A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-07 14:03 ` [PATCH] uapi glibc compat: fix cases where glibc net/if.h is included before linux/if.h Mikko Rapeli
[not found] ` <1454853801-18064-1-git-send-email-mikko.rapeli-X3B1VOXEql0@public.gmane.org>
2016-02-17 15:46 ` David Miller
[not found] ` <20160217.104620.239734387234680136.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2016-02-26 7:25 ` Mikko Rapeli
2016-02-26 16:28 ` David Miller
2016-02-25 20:53 ` header conflict introduced by change to netfilter_ipv4/ip_tables.h Daniel Borkmann
2016-02-26 7:13 ` Mikko Rapeli
2016-02-07 11:31 ` Kernel uapi and glibc header conflicts (was Re: header conflict introduced by change to netfilter_ipv4/ip_tables.h ) Mikko Rapeli
2016-02-08 13:59 ` Florian Weimer
2016-02-25 21:08 ` header conflict introduced by change to netfilter_ipv4/ip_tables.h Thomas Graf
2016-02-26 7:18 ` Mikko Rapeli
2016-02-26 9:13 ` Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160106092007.1c5a0c75@xeon-e3 \
--to=shemming@brocade.com \
--cc=mikko.rapeli@iki.fi \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).