From: Florian Westphal <fw@strlen.de>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf-next] nftables: ct: add byte/packet counter support
Date: Fri, 8 Jan 2016 02:37:08 +0100 [thread overview]
Message-ID: <20160108013708.GH23789@breakpoint.cc> (raw)
In-Reply-To: <20160108013311.GG23789@breakpoint.cc>
Florian Westphal <fw@strlen.de> wrote:
> Florian Westphal <fw@strlen.de> wrote:
> > + case NFT_CT_BYTES: /* fallthrough */
> > + case NFT_CT_PKTS: {
> > + const struct nf_conn_acct *acct = nf_conn_acct_find(ct);
> > + u64 count = 0;
> > +
> > + if (acct)
> > + count = nft_ct_get_eval_counter(acct->counter,
> > + priv->key, priv->dir);
> > + memcpy(dest, &count, sizeof(count));
>
> Seems this needs to be a put_unaligned(). V2 coming soon.
Ahem. No. This is fine.
Seems I need to rest, I'll send the nft_byteorder patch tomorrow.
Sorry.
next prev parent reply other threads:[~2016-01-08 1:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 20:34 [PATCH nf-next] nftables: ct: add byte/packet counter support Florian Westphal
2016-01-08 0:47 ` Florian Westphal
2016-01-08 1:33 ` Florian Westphal
2016-01-08 1:37 ` Florian Westphal [this message]
2016-01-08 12:38 ` Pablo Neira Ayuso
2016-01-08 12:43 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160108013708.GH23789@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).