From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [PATCH] netfilter: nft_ct: mark nft_ct_get_eval_counter __maybe_unused Date: Wed, 13 Jan 2016 16:54:24 +0100 Message-ID: <20160113155424.GA1581@salvia> References: <6200241.eeH6DHXzHj@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Patrick McHardy , Jozsef Kadlecsik , "David S. Miller" , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Florian Westphal To: Arnd Bergmann Return-path: Received: from mail.us.es ([193.147.175.20]:45866 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752221AbcAMPyd (ORCPT ); Wed, 13 Jan 2016 10:54:33 -0500 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 5173427A6A2 for ; Wed, 13 Jan 2016 16:54:32 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 4205FDA801 for ; Wed, 13 Jan 2016 16:54:32 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id CDB20DA80C for ; Wed, 13 Jan 2016 16:54:29 +0100 (CET) Content-Disposition: inline In-Reply-To: <6200241.eeH6DHXzHj@wuerfel> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Wed, Jan 13, 2016 at 02:58:11PM +0100, Arnd Bergmann wrote: > The newly added nft_ct_get_eval_counter() function is only used when > CONFIG_NF_CONNTRACK_LABELS is set, otherwise gcc warns about the > unused definition: > > netfilter/nft_ct.c:34:12: warning: 'nft_ct_get_eval_counter' defined but not used [-Wunused-function] > static u64 nft_ct_get_eval_counter(const struct nf_conn_counter *c, > > This marks the function __maybe_unused to shut up the warning. It seems that function doesn't below to CONFIG_NF_CONNTRACK_LABELS as it is part of the new counter support. Will be sending an alternate patch instead. Thanks anyway for your patch Arnd.