From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] netlink_delinearize: only remove protocol if equal cmp is used
Date: Wed, 27 Jan 2016 16:45:49 +0100 [thread overview]
Message-ID: <20160127154549.GA1330@salvia> (raw)
In-Reply-To: <1453902155-3077-1-git-send-email-fw@strlen.de>
On Wed, Jan 27, 2016 at 02:42:35PM +0100, Florian Westphal wrote:
> Check for OP_EQ before removing a dependency, else we may zap wrong one,
> changing the meaning of the rule.
>
> Listing without patch:
> ip protocol udp udp dport ssh
> ip protocol udp udp dport ssh
> counter packets 1 bytes 308 ip protocol udp udp dport ssh
>
> With patch:
> ip protocol != tcp udp dport ssh
> ip protocol != udp udp dport ssh
> ip protocol != tcp counter packets 1 bytes 308 udp dport ssh
Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
> Signed-off-by: Florian Westphal <fw@strlen.de>
> ---
> NB: ip protocol != udp udp dport ... is nonsensical, not sure
> if its worth the hassle to try to reject stuff like this.
I agree this is not worth. We'll have more advanced tools to perform
transformations and more in-depth semantic evaluation of the ruleset
at some point, but not now ;-)
prev parent reply other threads:[~2016-01-27 15:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-27 13:42 [PATCH nft] netlink_delinearize: only remove protocol if equal cmp is used Florian Westphal
2016-01-27 15:45 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160127154549.GA1330@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).