From: Simon Horman <horms@verge.net.au>
To: Julian Anastasov <ja@ssi.bg>
Cc: Arnd Bergmann <arnd@arndb.de>,
Wensong Zhang <wensong@linux-vs.org>,
linux-arm-kernel@lists.infradead.org,
Pablo Neira Ayuso <pablo@netfilter.org>,
Patrick McHardy <kaber@trash.net>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, lvs-devel@vger.kernel.org,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] netfilter: ipvs: avoid unused variable warnings
Date: Thu, 28 Jan 2016 08:39:53 +0900 [thread overview]
Message-ID: <20160127233953.GB5183@verge.net.au> (raw)
In-Reply-To: <alpine.LFD.2.11.1601272156590.2353@ja.home.ssi.bg>
On Wed, Jan 27, 2016 at 10:01:42PM +0200, Julian Anastasov wrote:
>
> Hello,
>
> On Wed, 27 Jan 2016, Arnd Bergmann wrote:
>
> > The proc_create() and remove_proc_entry() functions do not reference
> > their arguments when CONFIG_PROC_FS is disabled, so we get a couple
> > of warnings about unused variables in IPVS:
> >
> > ipvs/ip_vs_app.c:608:14: warning: unused variable 'net' [-Wunused-variable]
> > ipvs/ip_vs_ctl.c:3950:14: warning: unused variable 'net' [-Wunused-variable]
> > ipvs/ip_vs_ctl.c:3994:14: warning: unused variable 'net' [-Wunused-variable]
> >
> > This removes the local variables and instead looks them up separately
> > for each use, which obviously avoids the warning.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: 4c50a8ce2b63 ("netfilter: ipvs: avoid unused variable warning")
>
> Looks like your previous patch for ip_vs_app_net_cleanup
> was delayed in ipvs-next tree. I guess, Simon should drop it and
> use this one instead when net-next opens:
>
> Acked-by: Julian Anastasov <ja@ssi.bg>
Thanks, and sorry about not pushing the other patch to net-next.
I have dropped it and queued up this one in its place.
next prev parent reply other threads:[~2016-01-27 23:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-27 13:52 [PATCH 1/2] netfilter: ipvs: avoid unused variable warnings Arnd Bergmann
2016-01-27 13:52 ` [PATCH 2/2] netfilter: ipvs/SIP: handle ip_vs_fill_iph_skb_off failure Arnd Bergmann
2016-01-27 20:56 ` Julian Anastasov
2016-01-27 23:39 ` Simon Horman
2016-01-27 20:01 ` [PATCH 1/2] netfilter: ipvs: avoid unused variable warnings Julian Anastasov
2016-01-27 23:39 ` Simon Horman [this message]
2016-01-28 12:28 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160127233953.GB5183@verge.net.au \
--to=horms@verge.net.au \
--cc=arnd@arndb.de \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=ja@ssi.bg \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=wensong@linux-vs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).