From: Pablo Neira Ayuso <pablo@netfilter.org>
To: "Asbjørn Sloth Tønnesen" <ast@fiberby.dk>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH conntrack 4/4] tests: conntrack: use local conntrack binary
Date: Mon, 1 Feb 2016 12:00:33 +0100 [thread overview]
Message-ID: <20160201110033.GD8095@salvia> (raw)
In-Reply-To: <1453718430-5784-4-git-send-email-ast@fiberby.dk>
On Mon, Jan 25, 2016 at 10:40:30AM +0000, Asbjørn Sloth Tønnesen wrote:
> The binary under test should be the one, this ensures
> that it is in sync with the tests performed, and that
> users who build from source, can test the binary prior
> to `make install`.
>
> Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.dk>
> ---
>
> This is my preference, others might prefer it as it is.
> Maybe it should be possible to overwrite with an
> enviromental variable or an argument, currently test-conntrack.c
> doesn't take any arguments, but run-tests.sh passes the
> testdir as an argument.
I agree it makes sense to test what you have in your tree without
having to install it.
Applied, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-02-01 11:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 10:40 [PATCH conntrack 1/4] tests: conntrack: run testfiles in the correct order Asbjørn Sloth Tønnesen
2016-01-25 10:40 ` [PATCH conntrack 2/4] tests: conntrack: flush stdout to keep sync Asbjørn Sloth Tønnesen
2016-02-01 10:59 ` Pablo Neira Ayuso
2016-01-25 10:40 ` [PATCH conntrack 3/4] tests: conntrack: ignore dot files in testdir Asbjørn Sloth Tønnesen
2016-02-01 10:59 ` Pablo Neira Ayuso
2016-01-25 10:40 ` [PATCH conntrack 4/4] tests: conntrack: use local conntrack binary Asbjørn Sloth Tønnesen
2016-02-01 11:00 ` Pablo Neira Ayuso [this message]
2016-02-01 10:59 ` [PATCH conntrack 1/4] tests: conntrack: run testfiles in the correct order Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160201110033.GD8095@salvia \
--to=pablo@netfilter.org \
--cc=ast@fiberby.dk \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).