From: Pablo Neira Ayuso <pablo@netfilter.org>
To: "Asbjørn Sloth Tønnesen" <ast@fiberby.dk>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH conntrack 4/5 v2] conntrack: add support for netmask filtering
Date: Mon, 1 Feb 2016 12:04:23 +0100 [thread overview]
Message-ID: <20160201110423.GH8095@salvia> (raw)
In-Reply-To: <1453720548-14413-4-git-send-email-ast@fiberby.dk>
On Mon, Jan 25, 2016 at 11:15:47AM +0000, Asbjørn Sloth Tønnesen wrote:
> This patch extends --mask-src and --mask-dst to also work
> with the conntrack table, with commands -L, -D, -E and -U.
>
> Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.dk>
> ---
>
> Notes:
> This is almost completely backward compatible,
> since the --mask-* arguments previously gave
> an error is used with these commands and the
> conntrack table.
>
> I have changed the global_family to filter_family,
> and it is only used to pass the family to the callback,
> the alternative would be to change the data argument of
> the callbacks to a struct.
I see changes with regards to previous patchset, not we don't use
cidr. I think this is better since it allows a more compact way.
I prefer the cidr-based approach, any reason to drop it?
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-02-01 11:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 11:15 [PATCH conntrack 1/5] conntrack: support delete by label Asbjørn Sloth Tønnesen
2016-01-25 11:15 ` [PATCH conntrack 2/5] conntrack: consolidate filtering Asbjørn Sloth Tønnesen
2016-02-01 11:02 ` Pablo Neira Ayuso
2016-01-25 11:15 ` [PATCH conntrack 3/5] conntrack: cleanup: use switch statements for family checks Asbjørn Sloth Tønnesen
2016-02-01 11:02 ` Pablo Neira Ayuso
2016-01-25 11:15 ` [PATCH conntrack 4/5 v2] conntrack: add support for netmask filtering Asbjørn Sloth Tønnesen
2016-02-01 11:04 ` Pablo Neira Ayuso [this message]
2016-02-01 12:17 ` Asbjørn Sloth Tønnesen
2016-02-01 17:56 ` Pablo Neira Ayuso
2016-02-02 15:55 ` Asbjørn Sloth Tønnesen
2016-02-02 16:34 ` Pablo Neira Ayuso
2016-02-16 18:18 ` Pablo Neira Ayuso
2016-01-25 11:15 ` [PATCH conntrack 5/5 v2] tests: conntrack: add netmask tests Asbjørn Sloth Tønnesen
2016-02-16 18:18 ` Pablo Neira Ayuso
2016-02-01 11:02 ` [PATCH conntrack 1/5] conntrack: support delete by label Pablo Neira Ayuso
2016-02-01 11:20 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160201110423.GH8095@salvia \
--to=pablo@netfilter.org \
--cc=ast@fiberby.dk \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).