From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [PATCH net] nftables: use list_for_each_entry_safe_reverse to traversal commit_list in nf_tables_abort Date: Mon, 1 Feb 2016 12:08:23 +0100 Message-ID: <20160201110823.GA8361@salvia> References: <15bcb964221e1a9498e901417d020609cd5aac65.1449485287.git.lucien.xin@gmail.com> <20151209140330.GA1695@salvia> <20151213214709.GA1827@salvia> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: network dev , netfilter-devel@vger.kernel.org, davem , fw@strlen.de To: Xin Long Return-path: Received: from mail.us.es ([193.147.175.20]:58810 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752956AbcBALI1 (ORCPT ); Mon, 1 Feb 2016 06:08:27 -0500 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 83533C8812 for ; Mon, 1 Feb 2016 12:08:26 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 7327EDA870 for ; Mon, 1 Feb 2016 12:08:26 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 7E293DA86B for ; Mon, 1 Feb 2016 12:08:24 +0100 (CET) Content-Disposition: inline In-Reply-To: Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Mon, Feb 01, 2016 at 06:47:33PM +0800, Xin Long wrote: > > > > No need to resend. > > > > Yes, we need this reverse iteration there to handle the 'delete table' > > command in the batch. This problem happens since we have > > nft_flush_table(). > > > > Other callsites are artificially restriction deletion of inactive > > objects but that should be removed as we already discuss on the > > mailing list. > > > > So I'm applying this, thanks. > > Hi Pablo, has this one been applied ? commit a907e36d54e0ff836e55e04531be201bf6b4d8c8 Author: Xin Long Date: Mon Dec 7 18:48:07 2015 +0800 netfilter: nf_tables: use reverse traversal commit_list in nf_tables_abort