From: Florian Westphal <fw@strlen.de>
To: Patrick McHardy <kaber@trash.net>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft 2/3] meta: add prandom matching
Date: Thu, 4 Feb 2016 15:46:46 +0100 [thread overview]
Message-ID: <20160204144646.GA25780@breakpoint.cc> (raw)
In-Reply-To: <DB5D81F9-A143-4DE6-A315-465B72EA84B3@trash.net>
Patrick McHardy <kaber@trash.net> wrote:
> Am 2. Februar 2016 00:19:00 MEZ, schrieb Florian Westphal <fw@strlen.de>:
> >
> > enum datatypes {
> > TYPE_INVALID,
> >@@ -78,6 +79,7 @@ enum datatypes {
> > TYPE_ICMPV6_CODE,
> > TYPE_ICMPX_CODE,
> > TYPE_DEVGROUP,
> >+ TYPE_PROBABILITY,
> > __TYPE_MAX
> >
>
> Any reason why you chose to add this type instead of a generic floating point type?
I wanted 0.9999 be tranlated to a value close to UINT32_MAX and 0.00001
to something close to zero so that "meta random 0.999" can be translated to
something like
reg1 = prandom_u32()
reg1 <= 0xffffffee
I.e. this type cannot represent 5.2 (or whatever).
Does that answer your question?
next prev parent reply other threads:[~2016-02-04 14:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 23:18 [PATCH nft 0/3] meta: random match for statistic sampling Florian Westphal
2016-02-01 23:18 ` [PATCH nft 1/3] evaluate: move default op lookup into helper Florian Westphal
2016-02-01 23:19 ` [PATCH nft 2/3] meta: add prandom matching Florian Westphal
2016-02-04 14:39 ` Patrick McHardy
2016-02-04 14:46 ` Florian Westphal [this message]
2016-02-04 15:27 ` Patrick McHardy
2016-02-04 15:32 ` Florian Westphal
2016-02-04 16:09 ` Florian Westphal
2016-02-04 16:42 ` Florian Westphal
2016-02-04 17:40 ` Patrick McHardy
2016-02-15 12:54 ` Florian Westphal
2016-02-16 11:45 ` Pablo Neira Ayuso
2016-02-16 12:00 ` Florian Westphal
2016-02-16 16:28 ` Pablo Neira Ayuso
2016-02-04 17:38 ` Patrick McHardy
2016-02-01 23:19 ` [PATCH nft 3/3] tests: add test cases for meta random Florian Westphal
2016-02-03 20:23 ` [PATCH nft 0/3] meta: random match for statistic sampling Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160204144646.GA25780@breakpoint.cc \
--to=fw@strlen.de \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).