From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [PATCH] netfilter: tee: select NF_DUP_IPV6 unconditionally Date: Mon, 15 Feb 2016 19:14:36 +0100 Message-ID: <20160215181436.GA3462@salvia> References: <1454664040-1344109-1-git-send-email-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-arm-kernel@lists.infradead.org, Patrick McHardy , Jozsef Kadlecsik , "David S. Miller" , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Arnd Bergmann Return-path: Received: from mail.us.es ([193.147.175.20]:43991 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752621AbcBOSOl (ORCPT ); Mon, 15 Feb 2016 13:14:41 -0500 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id DA29CE665D for ; Mon, 15 Feb 2016 19:14:39 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id CB90691DD for ; Mon, 15 Feb 2016 19:14:39 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 5C3FF91DE for ; Mon, 15 Feb 2016 19:14:37 +0100 (CET) Content-Disposition: inline In-Reply-To: <1454664040-1344109-1-git-send-email-arnd@arndb.de> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Fri, Feb 05, 2016 at 10:20:21AM +0100, Arnd Bergmann wrote: > The NETFILTER_XT_TARGET_TEE option selects NF_DUP_IPV6 whenever > IP6_NF_IPTABLES is enabled, and it ensures that it cannot be > builtin itself if NF_CONNTRACK is a loadable module, as that > is a dependency for NF_DUP_IPV6. > > However, NF_DUP_IPV6 can be enabled even if IP6_NF_IPTABLES is > turned off, and it only really depends on IPV6. With the current > check in tee_tg6, we call nf_dup_ipv6() whenever NF_DUP_IPV6 > is enabled. This can however be a loadable module which is > unreachable from a built-in xt_TEE: > > net/built-in.o: In function `tee_tg6': > :(.text+0x67728): undefined reference to `nf_dup_ipv6' > > The bug was originally introduced in the split of the xt_TEE module > into separate modules for ipv4 and ipv6, and two patches tried > to fix it unsuccessfully afterwards. > > This is a revert of the the first incorrect attempt to fix it, > going back to depending on IPV6 as the dependency, and we > adapt the 'select' condition accordingly. Applied, thanks Arnd.