From: Pablo Neira Ayuso <pablo@netfilter.org>
To: "Asbjørn Sloth Tønnesen" <ast@fiberby.dk>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH conntrack 4/4] tests: conntrack: add tests for CIDR notation
Date: Tue, 16 Feb 2016 19:20:39 +0100 [thread overview]
Message-ID: <20160216182039.GF20397@salvia> (raw)
In-Reply-To: <1454333407-6335-4-git-send-email-ast@fiberby.dk>
On Mon, Feb 01, 2016 at 01:30:07PM +0000, Asbjørn Sloth Tønnesen wrote:
> Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.dk>
> ---
> tests/conntrack/testsuite/01delete | 4 ++++
> tests/conntrack/testsuite/02filter | 2 ++
> 2 files changed, 6 insertions(+)
>
> diff --git a/tests/conntrack/testsuite/01delete b/tests/conntrack/testsuite/01delete
> index 566b89f..194d999 100644
> --- a/tests/conntrack/testsuite/01delete
> +++ b/tests/conntrack/testsuite/01delete
> @@ -10,3 +10,7 @@
> -D -s 1.1.1.0 --mask-src 255.255.255.0 -d 2.2.2.0 --mask-dst 255.255.255.0 ; OK
> # fails due to 0 matches
> -D -s 1.1.1.0 --mask-src 255.255.255.0 -d 2.2.2.0 --mask-dst 255.255.255.0 ; BAD
> +# re-create dummy
> +-I -s 1.1.1.1 -d 2.2.2.2 -p tcp --sport 10 --dport 20 --state LISTEN -u SEEN_REPLY -t 50 ; OK
> +# try same command again but with CIDR
> +-D -s 1.1.1.0/24 -d 2.2.2.0/24 ; OK
> diff --git a/tests/conntrack/testsuite/02filter b/tests/conntrack/testsuite/02filter
> index 5d2270b..58ed070 100644
> --- a/tests/conntrack/testsuite/02filter
> +++ b/tests/conntrack/testsuite/02filter
> @@ -21,5 +21,7 @@ conntrack -L --mark 0 ; OK
> conntrack -L --mark 0/0xffffffff; OK
> # filter by netmask
> conntrack -L -s 1.1.1.0 --mask-src 255.255.255.0 -d 2.0.0.0 --mask-dst 255.0.0.0 ; OK
> +conntrack -L -s 1.1.1.4/24 -d 2.3.4.5/8 ; OK
> +conntrack -L -s 1.1.2.0/24 -d 2.3.4.5/8 ; BAD
I have mangled the line above from BAD to OK. The listing above
actually works fine, even if it returns no entries. The tests are not
capable of catching this at the moment IIRC.
So applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-02-16 18:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 13:30 [PATCH conntrack 1/4] conntrack: split up nfct_set_addr_from_opt() Asbjørn Sloth Tønnesen
2016-02-01 13:30 ` [PATCH conntrack 2/4 v2] conntrack: extend parse_addr() with CIDR support Asbjørn Sloth Tønnesen
2016-02-16 18:19 ` Pablo Neira Ayuso
2016-02-01 13:30 ` [PATCH conntrack 3/4 v2] conntrack: add support for CIDR notation Asbjørn Sloth Tønnesen
2016-02-16 18:19 ` Pablo Neira Ayuso
2016-02-01 13:30 ` [PATCH conntrack 4/4] tests: conntrack: add tests " Asbjørn Sloth Tønnesen
2016-02-16 18:20 ` Pablo Neira Ayuso [this message]
2016-02-16 18:18 ` [PATCH conntrack 1/4] conntrack: split up nfct_set_addr_from_opt() Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160216182039.GF20397@salvia \
--to=pablo@netfilter.org \
--cc=ast@fiberby.dk \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).