* [PATCH nf] netfilter: nfnetlink_acct: validate NFACCT_FILTER parameters
@ 2016-02-24 20:34 Phil Turnbull
2016-02-29 12:35 ` Pablo Neira Ayuso
0 siblings, 1 reply; 2+ messages in thread
From: Phil Turnbull @ 2016-02-24 20:34 UTC (permalink / raw)
To: netfilter-devel
Cc: Pablo Neira Ayuso, Patrick McHardy, Jozsef Kadlecsik, coreteam,
Phil Turnbull
nfacct_filter_alloc doesn't validate the NFACCT_FILTER_MASK and
NFACCT_FILTER_VALUE parameters which can trigger a NULL pointer
dereference. CAP_NET_ADMIN is required to trigger the bug.
Signed-off-by: Phil Turnbull <phil.turnbull@oracle.com>
---
net/netfilter/nfnetlink_acct.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/net/netfilter/nfnetlink_acct.c b/net/netfilter/nfnetlink_acct.c
index 5274b04..4c2b4c0 100644
--- a/net/netfilter/nfnetlink_acct.c
+++ b/net/netfilter/nfnetlink_acct.c
@@ -242,6 +242,9 @@ nfacct_filter_alloc(const struct nlattr * const attr)
if (err < 0)
return ERR_PTR(err);
+ if (!tb[NFACCT_FILTER_MASK] || !tb[NFACCT_FILTER_VALUE])
+ return ERR_PTR(-EINVAL);
+
filter = kzalloc(sizeof(struct nfacct_filter), GFP_KERNEL);
if (!filter)
return ERR_PTR(-ENOMEM);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH nf] netfilter: nfnetlink_acct: validate NFACCT_FILTER parameters
2016-02-24 20:34 [PATCH nf] netfilter: nfnetlink_acct: validate NFACCT_FILTER parameters Phil Turnbull
@ 2016-02-29 12:35 ` Pablo Neira Ayuso
0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2016-02-29 12:35 UTC (permalink / raw)
To: Phil Turnbull
Cc: netfilter-devel, Patrick McHardy, Jozsef Kadlecsik, coreteam
On Wed, Feb 24, 2016 at 03:34:43PM -0500, Phil Turnbull wrote:
> nfacct_filter_alloc doesn't validate the NFACCT_FILTER_MASK and
> NFACCT_FILTER_VALUE parameters which can trigger a NULL pointer
> dereference. CAP_NET_ADMIN is required to trigger the bug.
Applied, thanks.
I have enqueued this to -stable: 3.18, 4.1 and 4.4
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-29 12:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-24 20:34 [PATCH nf] netfilter: nfnetlink_acct: validate NFACCT_FILTER parameters Phil Turnbull
2016-02-29 12:35 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).