From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: Laura Garcia Liebana <nevola@gmail.com>,
netfilter-devel@vger.kernel.org, shivanib134@gmail.com,
outreachy-kernel@googlegroups.com
Subject: Re: [PATCH v3] extensions: libxt_statistic: Add translation to nft
Date: Wed, 2 Mar 2016 13:46:26 +0100 [thread overview]
Message-ID: <20160302124626.GA5243@salvia> (raw)
In-Reply-To: <20160302123738.GB4348@breakpoint.cc>
On Wed, Mar 02, 2016 at 01:37:38PM +0100, Florian Westphal wrote:
> Pablo Neira Ayuso <pablo@netfilter.org> wrote:
>
> [ nft meta random ]
>
> > I'm fine with the probability scaling, but I think we should keep this
> > consistent with other selectors, so I would use lt and gte instead
> > here.
> >
> > We can potentially use ranges here too and other available operations
> > such as prefixes (although this one I don't know use case for this).
>
> Ok, so just to clarify. You want me to submit v2 of nft meta random
> patch set that turns:
>
> meta random value
> into
> meta random lt value
>
> ... and ...
>
> meta random ne value
> into
> meta random ge value
>
> Is that correct?
I think so, so this becomes consistent with other selectors that we
have. Does this sound reasonable to you?
next prev parent reply other threads:[~2016-03-02 12:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 20:40 [PATCH v3] extensions: libxt_statistic: Add translation to nft Laura Garcia Liebana
2016-03-02 11:46 ` Pablo Neira Ayuso
2016-03-02 12:10 ` Florian Westphal
2016-03-02 12:33 ` Pablo Neira Ayuso
2016-03-02 12:37 ` Florian Westphal
2016-03-02 12:46 ` Pablo Neira Ayuso [this message]
2016-03-02 13:44 ` Florian Westphal
2016-03-02 13:52 ` Jan Engelhardt
2016-03-02 14:50 ` Florian Westphal
2016-03-02 14:54 ` Jan Engelhardt
2016-03-02 14:59 ` Florian Westphal
2016-03-02 15:17 ` Pablo Neira Ayuso
2016-03-02 15:29 ` Florian Westphal
2016-03-02 15:56 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160302124626.GA5243@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=nevola@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
--cc=shivanib134@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).