netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Shivani Bhardwaj <shivanib134@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] extensions: libxt_dccp: Add translation to nft
Date: Thu, 3 Mar 2016 18:59:30 +0100	[thread overview]
Message-ID: <20160303175930.GA2055@salvia> (raw)
In-Reply-To: <20160301131133.GA9134@gmail.com>

On Tue, Mar 01, 2016 at 06:41:33PM +0530, Shivani Bhardwaj wrote:
> Add translation for dccp to nftables.
> 
> Full translation of this match awaits the support for --dccp-option.
> Also, since inversion of set is not possible in nftables, using dccp
> with rules like
> ...dccp type != {request, response}..
> is going to throw errors.

Yes, this needs a small patch for the kernel and some userspace bits.
Please document that we need inversion of sets support in the wiki so
we can assign this task to someone.

> Examples:
> 
> $ sudo iptables-translate -A INPUT -p dccp -m dccp --sport 100
> nft add rule ip filter INPUT dccp sport 100 counter
> 
> $ sudo iptables-translate -A INPUT -p dccp -m dccp --dport 100:200
> nft add rule ip filter INPUT dccp dport 100-200 counter
> 
> $ sudo iptables-translate -A INPUT -p dccp -m dccp ! --dport 100
> nft add rule ip filter INPUT dccp dport != 100 counter
> 
> $ sudo iptables-translate -A INPUT -p dccp -m dccp --dccp-type REQUEST,RESPONSE
> nft add rule ip filter INPUT dccp type {request, response} counter

Could you send a v2 removing the invalid type as it doesn't make any
sense?

Thanks.

      reply	other threads:[~2016-03-03 17:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-01 13:11 [PATCH] extensions: libxt_dccp: Add translation to nft Shivani Bhardwaj
2016-03-03 17:59 ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160303175930.GA2055@salvia \
    --to=pablo@netfilter.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=shivanib134@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).