netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: Shivani Bhardwaj <shivanib134@gmail.com>,
	netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] extensions: libxt_connlabel: Add translation to nft
Date: Mon, 7 Mar 2016 14:05:24 +0100	[thread overview]
Message-ID: <20160307130524.GA26624@salvia> (raw)
In-Reply-To: <20160306000703.GA31513@breakpoint.cc>

On Sun, Mar 06, 2016 at 01:07:03AM +0100, Florian Westphal wrote:
> Shivani Bhardwaj <shivanib134@gmail.com> wrote:
> > Add translation for connlabel to nftables.
> > Full translation for this match awaits the support for --set option.
> 
> Hmm, I sent patches for that a while ago, don't know why they were
> not applied... Pablo?

Please, push the the connlabel support to nft.

We can probably introduce something like:

        ct connlabel bitset bar

instead of:

        ct connlabel set ct connlabel | bar

in a follow up patch, which looks more compact to me. We can accept
both syntax I'd say so we can introduce this without breaking
backward.

  reply	other threads:[~2016-03-07 13:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-05 21:47 [PATCH] extensions: libxt_connlabel: Add translation to nft Shivani Bhardwaj
2016-03-06  0:07 ` Florian Westphal
2016-03-07 13:05   ` Pablo Neira Ayuso [this message]
2016-03-07 13:25     ` Shivani Bhardwaj
2016-03-07 13:30       ` Florian Westphal
2016-03-07 13:33         ` Pablo Neira Ayuso
2016-03-07 13:32       ` Pablo Neira Ayuso
2016-03-07 13:33         ` Shivani Bhardwaj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160307130524.GA26624@salvia \
    --to=pablo@netfilter.org \
    --cc=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=shivanib134@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).