From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Westphal Subject: Re: [PATCH] extensions: libxt_connlabel: Add translation to nft Date: Mon, 7 Mar 2016 14:30:04 +0100 Message-ID: <20160307133004.GB776@breakpoint.cc> References: <20160305214746.GA16464@gmail.com> <20160306000703.GA31513@breakpoint.cc> <20160307130524.GA26624@salvia> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Pablo Neira Ayuso , Florian Westphal , Netfilter Development Mailing list To: Shivani Bhardwaj Return-path: Received: from Chamillionaire.breakpoint.cc ([80.244.247.6]:34480 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751000AbcCGNaH (ORCPT ); Mon, 7 Mar 2016 08:30:07 -0500 Content-Disposition: inline In-Reply-To: Sender: netfilter-devel-owner@vger.kernel.org List-ID: Shivani Bhardwaj wrote: > On Mon, Mar 7, 2016 at 6:35 PM, Pablo Neira Ayuso wrote: > > On Sun, Mar 06, 2016 at 01:07:03AM +0100, Florian Westphal wrote: > >> Shivani Bhardwaj wrote: > >> > Add translation for connlabel to nftables. > >> > Full translation for this match awaits the support for --set option. > >> > >> Hmm, I sent patches for that a while ago, don't know why they were > >> not applied... Pablo? > > > > Please, push the the connlabel support to nft. > > > > We can probably introduce something like: > > > > ct connlabel bitset bar > > > > instead of: > > > > ct connlabel set ct connlabel | bar > > > > in a follow up patch, which looks more compact to me. We can accept > > both syntax I'd say so we can introduce this without breaking > > backward. > > Should I be waiting for this or send a v2 with the existing options? > Please let me know. I'd suggest you just send a v2, lets handle translation of --set in a followup change later. I'm currently not at home but I plan to push set support this week.