netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: Shivani Bhardwaj <shivanib134@gmail.com>,
	Netfilter Development Mailing list
	<netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH] extensions: libxt_connlabel: Add translation to nft
Date: Mon, 7 Mar 2016 14:33:25 +0100	[thread overview]
Message-ID: <20160307133325.GA27057@salvia> (raw)
In-Reply-To: <20160307133004.GB776@breakpoint.cc>

On Mon, Mar 07, 2016 at 02:30:04PM +0100, Florian Westphal wrote:
> Shivani Bhardwaj <shivanib134@gmail.com> wrote:
> > On Mon, Mar 7, 2016 at 6:35 PM, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > > On Sun, Mar 06, 2016 at 01:07:03AM +0100, Florian Westphal wrote:
> > >> Shivani Bhardwaj <shivanib134@gmail.com> wrote:
> > >> > Add translation for connlabel to nftables.
> > >> > Full translation for this match awaits the support for --set option.
> > >>
> > >> Hmm, I sent patches for that a while ago, don't know why they were
> > >> not applied... Pablo?
> > >
> > > Please, push the the connlabel support to nft.
> > >
> > > We can probably introduce something like:
> > >
> > >         ct connlabel bitset bar
> > >
> > > instead of:
> > >
> > >         ct connlabel set ct connlabel | bar
> > >
> > > in a follow up patch, which looks more compact to me. We can accept
> > > both syntax I'd say so we can introduce this without breaking
> > > backward.
> > 
> > Should I be waiting for this or send a v2 with the existing options?
> > Please let me know.
> 
> I'd suggest you just send a v2, lets handle translation of --set in
> a followup change later.
>
> I'm currently not at home but I plan to push set support this week.

OK; then please wait to send a v2 Shivani.

  reply	other threads:[~2016-03-07 13:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-05 21:47 [PATCH] extensions: libxt_connlabel: Add translation to nft Shivani Bhardwaj
2016-03-06  0:07 ` Florian Westphal
2016-03-07 13:05   ` Pablo Neira Ayuso
2016-03-07 13:25     ` Shivani Bhardwaj
2016-03-07 13:30       ` Florian Westphal
2016-03-07 13:33         ` Pablo Neira Ayuso [this message]
2016-03-07 13:32       ` Pablo Neira Ayuso
2016-03-07 13:33         ` Shivani Bhardwaj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160307133325.GA27057@salvia \
    --to=pablo@netfilter.org \
    --cc=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=shivanib134@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).