From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [PATCH] extensions: libxt_connlabel: Add translation to nft Date: Mon, 7 Mar 2016 14:33:25 +0100 Message-ID: <20160307133325.GA27057@salvia> References: <20160305214746.GA16464@gmail.com> <20160306000703.GA31513@breakpoint.cc> <20160307130524.GA26624@salvia> <20160307133004.GB776@breakpoint.cc> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Shivani Bhardwaj , Netfilter Development Mailing list To: Florian Westphal Return-path: Received: from mail.us.es ([193.147.175.20]:49621 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752729AbcCGNdl (ORCPT ); Mon, 7 Mar 2016 08:33:41 -0500 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 3D217C1252 for ; Mon, 7 Mar 2016 14:33:40 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 0E8D0DA39E for ; Mon, 7 Mar 2016 14:33:40 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 51527CA119 for ; Mon, 7 Mar 2016 14:33:27 +0100 (CET) Content-Disposition: inline In-Reply-To: <20160307133004.GB776@breakpoint.cc> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Mon, Mar 07, 2016 at 02:30:04PM +0100, Florian Westphal wrote: > Shivani Bhardwaj wrote: > > On Mon, Mar 7, 2016 at 6:35 PM, Pablo Neira Ayuso wrote: > > > On Sun, Mar 06, 2016 at 01:07:03AM +0100, Florian Westphal wrote: > > >> Shivani Bhardwaj wrote: > > >> > Add translation for connlabel to nftables. > > >> > Full translation for this match awaits the support for --set option. > > >> > > >> Hmm, I sent patches for that a while ago, don't know why they were > > >> not applied... Pablo? > > > > > > Please, push the the connlabel support to nft. > > > > > > We can probably introduce something like: > > > > > > ct connlabel bitset bar > > > > > > instead of: > > > > > > ct connlabel set ct connlabel | bar > > > > > > in a follow up patch, which looks more compact to me. We can accept > > > both syntax I'd say so we can introduce this without breaking > > > backward. > > > > Should I be waiting for this or send a v2 with the existing options? > > Please let me know. > > I'd suggest you just send a v2, lets handle translation of --set in > a followup change later. > > I'm currently not at home but I plan to push set support this week. OK; then please wait to send a v2 Shivani.