From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Laura Garcia Liebana <nevola@gmail.com>
Cc: netfilter-devel@vger.kernel.org, shivanib134@gmail.com,
outreachy-kernel@googlegroups.com
Subject: Re: [PATCHv2] extensions: libipt_icmp: Add translation to nft
Date: Mon, 7 Mar 2016 17:58:53 +0100 [thread overview]
Message-ID: <20160307165853.GA29439@salvia> (raw)
In-Reply-To: <20160306222442.GA20945@sonyv>
On Sun, Mar 06, 2016 at 11:24:44PM +0100, Laura Garcia Liebana wrote:
> Add translation for icmp to nftables. Not supported types in nftables
> are: any, network-unreachable, host-unreachable, protocol-unreachable,
> port-unreachable, fragmentation-needed, source-route-failed,
> network-unknown, host-unknown, network-prohibited, host-prohibited,
> TOS-network-unreachable, TOS-host-unreachable, communication-prohibited,
> host-precedence-violation, precedence-cutoff, network-redirect,
> host-redirect, TOS-network-redirect, TOS-host-redirect,
> router-advertisement, router-solicitation, ttl-zero-during-transit,
> ttl-zero-during-reassembly, ip-header-bad and required-option-missing.
Oh I see, these are actually the non-supported icmp codes at this
moment, instead of the icmp types.
All icmp types should work, if any missing, we should add them. For
icmp codes, we need a fix for the listing side of nft.
Then, please return 0 when icmp codes are specified by now, document
this in the wiki and here in the description.
Thanks.
next prev parent reply other threads:[~2016-03-07 16:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-06 22:24 [PATCHv2] extensions: libipt_icmp: Add translation to nft Laura Garcia Liebana
2016-03-07 16:58 ` Pablo Neira Ayuso [this message]
2016-03-07 17:14 ` Pablo Neira Ayuso
2016-03-07 18:04 ` Laura Garcia
2016-03-07 18:10 ` Shivani Bhardwaj
2016-03-07 18:27 ` Pablo Neira Ayuso
2016-03-07 18:20 ` Pablo Neira Ayuso
2016-03-07 18:50 ` Laura Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160307165853.GA29439@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=nevola@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
--cc=shivanib134@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).