netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: gorcunov@gmail.com
Cc: alexei.starovoitov@gmail.com, eric.dumazet@gmail.com,
	netdev@vger.kernel.org, solar@openwall.com, vvs@virtuozzo.com,
	avagin@virtuozzo.com, xemul@virtuozzo.com,
	vdavydov@virtuozzo.com, khorenko@virtuozzo.com,
	pablo@netfilter.org, netfilter-devel@vger.kernel.org
Subject: Re: [RFC] net: ipv4 -- Introduce ifa limit per net
Date: Wed, 09 Mar 2016 16:10:38 -0500 (EST)	[thread overview]
Message-ID: <20160309.161038.283281065293712589.davem@davemloft.net> (raw)
In-Reply-To: <20160309205746.GQ2207@uranus.lan>

From: Cyrill Gorcunov <gorcunov@gmail.com>
Date: Wed, 9 Mar 2016 23:57:47 +0300

> Aha! So in your patch __inet_del_ifa bypass first blocking_notifier_call_chain
> 
> __inet_del_ifa
> 	...
> 	if (in_dev->dead)
> 		goto no_promotions;
> 
> 	// First call to NETDEV_DOWN
> ...
> no_promotions:
> 	rtmsg_ifa(RTM_DELADDR, ifa1, nlh, portid);
> 	blocking_notifier_call_chain(&inetaddr_chain, NETDEV_DOWN, ifa1);
> 
> and here we call for NETDEV_DOWN, which then hits masq_device_event
> and go further to conntrack code.

Yes that's where the notifier comes from, which happens with or without
my patch.

  reply	other threads:[~2016-03-09 21:10 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20160309175307.GM2207@uranus.lan>
     [not found] ` <20160309.152730.691838022304871697.davem@davemloft.net>
     [not found]   ` <20160309204158.GO2207@uranus.lan>
2016-03-09 20:47     ` [RFC] net: ipv4 -- Introduce ifa limit per net David Miller
2016-03-09 20:57       ` Cyrill Gorcunov
2016-03-09 21:10         ` David Miller [this message]
2016-03-09 21:16           ` Cyrill Gorcunov
2016-03-10 10:20             ` Cyrill Gorcunov
2016-03-10 11:03               ` Cyrill Gorcunov
2016-03-10 15:09                 ` Cyrill Gorcunov
2016-03-10 18:01                   ` David Miller
2016-03-10 18:48                     ` Cyrill Gorcunov
2016-03-10 19:02                     ` Cong Wang
2016-03-10 19:55                       ` David Miller
2016-03-10 20:01                         ` Cyrill Gorcunov
2016-03-10 20:03                           ` David Miller
2016-03-10 20:13                             ` Cyrill Gorcunov
2016-03-10 20:19                               ` Cyrill Gorcunov
2016-03-10 21:05                               ` David Miller
2016-03-10 21:19                                 ` Cyrill Gorcunov
2016-03-10 21:59                                   ` Cyrill Gorcunov
2016-03-10 22:36                                     ` David Miller
2016-03-10 22:40                                       ` Cyrill Gorcunov
2016-03-11 20:40                                         ` David Miller
2016-03-11 20:58                                           ` Florian Westphal
2016-03-11 21:00                                           ` Cyrill Gorcunov
2016-03-11 21:22                                           ` Cyrill Gorcunov
2016-03-11 21:59                                             ` Cyrill Gorcunov
2016-03-14  3:29                                               ` David Miller
2016-03-10 21:09                         ` Cong Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160309.161038.283281065293712589.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=alexei.starovoitov@gmail.com \
    --cc=avagin@virtuozzo.com \
    --cc=eric.dumazet@gmail.com \
    --cc=gorcunov@gmail.com \
    --cc=khorenko@virtuozzo.com \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=solar@openwall.com \
    --cc=vdavydov@virtuozzo.com \
    --cc=vvs@virtuozzo.com \
    --cc=xemul@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).