Re: [PATCH] libip6t_hbh: Add translation to nft

[Pablo Neira Ayuso <pablo@netfilter.org>]

On Wed, Mar 09, 2016 at 12:42:45PM +0530, FaTe wrote:
> Added translation for hbh module .
> 
> Note: Currently, --hbh-opts support dont exist in nftables .
> 
> Example :
> $ ip6tables-translate -A INPUT -m hbh --hbh-len 40
> nft add rule ip6 filter INPUT hbh hdrlength  40 counter
> 
> $ sudo ip6tables-translate -A INPUT -m hbh ! --hbh-len 40
> nft add rule ip6 filter INPUT hbh hdrlength  != 40 counter
> 
> Signed-off-by: Piyush Pangtey <gokuvsvegita@gmail.com>
> ---
>  extensions/libip6t_hbh.c | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/extensions/libip6t_hbh.c b/extensions/libip6t_hbh.c
> index c0389ed..98dcade 100644
> --- a/extensions/libip6t_hbh.c
> +++ b/extensions/libip6t_hbh.c
> @@ -164,6 +164,27 @@ static void hbh_save(const void *ip, const struct xt_entry_match *match)
>  	print_options(optinfo->optsnr, (uint16_t *)optinfo->opts);
>  }
>  
> +static int hbh_xlate(const struct xt_entry_match *match, struct xt_xlate *xl,
> +		     int numeric)
> +{
> +	const struct ip6t_opts *optinfo = (struct ip6t_opts *)match->data;
> +
> +	if (optinfo->flags & IP6T_OPTS_LEN) {
> +		xt_xlate_add(xl," hbh hdrlength %s %u",
> +			    (optinfo->invflags & IP6T_OPTS_INV_LEN) ? " !=" :
> +			    "", optinfo->hdrlen);

I suggested Shivani you check how to translate:

ip6tables -I INPUT -m hbh

which seems to be value too.

http://www.spinics.net/lists/netfilter-devel/msg41045.html

So we make sure we provide a right translation for that too.