netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Piyush Pangtey <gokuvsvegita@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH v4] extensions: libxt_multiport: Add translation to nft
Date: Sat, 12 Mar 2016 12:48:34 +0100	[thread overview]
Message-ID: <20160312114834.GA2229@salvia> (raw)
In-Reply-To: <20160311113604.GA4217@fate>

On Fri, Mar 11, 2016 at 05:06:04PM +0530, Piyush Pangtey wrote:
> Added full translation for multiport
> 
> Examples :
> $ iptables-translate -A input -p tcp -m multiport --ports ssh:http -j ACCEPT
> nft add rule ip filter input ip protocol tcp tcp dport { ssh - http } tcp sport
> { ssh - http } counter accept

You can translate this as:

        nft add rule ip filter input ip protocol tcp tcp dport ssh-http ...

without the brackets.

The brackets have special semantics, they mean that the kernel will
use the set infrastructure to define the range. However, we don't need
a set for this small range since we support ranges natively.

Please, fix and resubmit, thanks.

  reply	other threads:[~2016-03-12 11:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-11 11:36 [PATCH v4] extensions: libxt_multiport: Add translation to nft Piyush Pangtey
2016-03-12 11:48 ` Pablo Neira Ayuso [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-03-11 11:58 Piyush Pangtey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160312114834.GA2229@salvia \
    --to=pablo@netfilter.org \
    --cc=gokuvsvegita@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).