From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Weongyo Jeong <weongyo.linux@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] Shows proper function name for pr_debug() messages.
Date: Tue, 15 Mar 2016 01:15:01 +0100 [thread overview]
Message-ID: <20160315001501.GA27056@salvia> (raw)
In-Reply-To: <20160314200733.GA8907@jwg>
On Mon, Mar 14, 2016 at 01:07:36PM -0700, Weongyo Jeong wrote:
> It seems pr_debug() calls didn't be updated while code was refactoring.
Better add:
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
at the top of the file.
Have a look at beacd3e8ef23 ("netfilter: nfnetlink_log: Make use of
pr_fmt where applicable") for instance.
next prev parent reply other threads:[~2016-03-15 0:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-14 20:07 [PATCH] Shows proper function name for pr_debug() messages Weongyo Jeong
2016-03-15 0:15 ` Pablo Neira Ayuso [this message]
2016-03-15 17:59 ` Weongyo Jeong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160315001501.GA27056@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=weongyo.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).