netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Piyush Pangtey <gokuvsvegita@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] nft: Remove memory-leak
Date: Tue, 15 Mar 2016 01:26:26 +0100	[thread overview]
Message-ID: <20160315002626.GA9628@salvia> (raw)
In-Reply-To: <20160314084153.GA4064@fate>

On Mon, Mar 14, 2016 at 02:11:53PM +0530, Piyush Pangtey wrote:
> Added matching xfree calls in chain_free(), for the chain members 'type' and
> 'dev'.

Please, reintroduce the valgrind message for the record.

It would be good too if you add to the descriptions the nft command you
use to trigger the valgrind leak reports.

Thanks.

      reply	other threads:[~2016-03-15  0:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-14  8:41 [PATCH] nft: Remove memory-leak Piyush Pangtey
2016-03-15  0:26 ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160315002626.GA9628@salvia \
    --to=pablo@netfilter.org \
    --cc=gokuvsvegita@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).