From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft 3/3] ct: add conntrack label set support
Date: Wed, 16 Mar 2016 00:01:32 +0100 [thread overview]
Message-ID: <20160315230132.GC8185@breakpoint.cc> (raw)
In-Reply-To: <20160315171157.GB25284@salvia>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> If we have some generic way to parse immediates, this would look like:
>
> if (nfntl_attr_is_set(nle, NFTNL_EXPR_CT_SREG)) {
> ...
> } else if (nftnl_attr_is_set(nle, NFTNL_EXPR_CT_IMM)) {
> ...
> }
>
> Would this look nicer this way to you?
I'll give it a try.
We can't escape a bit more work anyway as the _IMM type will depend
on the key.
prev parent reply other threads:[~2016-03-15 23:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-15 16:10 [RFC PATCH 0/3] connlabel set support using extra setter attr Florian Westphal
2016-03-15 16:10 ` [PATCH nf-next 1/3] netfilter: nftables: add connlabel set support Florian Westphal
2016-03-15 17:08 ` Pablo Neira Ayuso
2016-03-15 23:09 ` Florian Westphal
2016-03-16 9:39 ` Florian Westphal
2016-03-16 13:17 ` Pablo Neira Ayuso
2016-03-16 13:31 ` Florian Westphal
2016-03-16 13:35 ` Pablo Neira Ayuso
2016-03-16 13:18 ` Pablo Neira Ayuso
2016-03-15 16:10 ` [PATCH libnftl 2/3] ct: add label " Florian Westphal
2016-03-15 16:10 ` [PATCH nft 3/3] ct: add conntrack " Florian Westphal
2016-03-15 17:11 ` Pablo Neira Ayuso
2016-03-15 23:01 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160315230132.GC8185@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).