From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH] tests/shell: add new testcases for commit/rollback
Date: Tue, 22 Mar 2016 19:49:55 +0100 [thread overview]
Message-ID: <20160322184955.GA6521@salvia> (raw)
In-Reply-To: <145830792808.5446.13784125186138242867.stgit@r2d2.cica.es>
On Fri, Mar 18, 2016 at 02:32:08PM +0100, Arturo Borrero Gonzalez wrote:
> New simple testcases for kernel commit/rollback operations.
>
> * ruleset A is loaded (good ruleset)
> * ruleset B is loaded (bad ruleset): fail is expected
> * ruleset A should remain in the kernel
$ git am nft-tests-shell-add-new-testcases-for-commit-rollback.patch -s
Applying: tests/shell: add new testcases for commit/rollback
patch:50: trailing whitespace.
ct state new
patch:51: trailing whitespace.
tcp dport { 22222}
patch:52: trailing whitespace.
ip saddr @t drop
patch:53: trailing whitespace.
jump other
patch:123: trailing whitespace.
ct state new
warning: squelched 15 whitespace errors
warning: 20 lines add whitespace errors.
I guess you're getting this from the output of nft, but this generates
a bit of noise in git when trying to apply this.
Could you have a look and resubmit? Thanks.
prev parent reply other threads:[~2016-03-22 18:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-18 13:32 [nft PATCH] tests/shell: add new testcases for commit/rollback Arturo Borrero Gonzalez
2016-03-22 18:49 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160322184955.GA6521@salvia \
--to=pablo@netfilter.org \
--cc=arturo.borrero.glez@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).