From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Nikolay Borisov <kernel@kyup.com>
Cc: Liping Zhang <zlpwmdx@163.com>,
netfilter-devel@vger.kernel.org, kaber@trash.net,
davem@davemloft.net, Liping Zhang <liping.zhang@spreadtrum.com>
Subject: Re: [PATCH] netfilter: ipv4: fix NULL dereference
Date: Thu, 24 Mar 2016 21:16:44 +0100 [thread overview]
Message-ID: <20160324201644.GB1561@salvia> (raw)
In-Reply-To: <56F39E82.4090902@kyup.com>
On Thu, Mar 24, 2016 at 10:00:02AM +0200, Nikolay Borisov wrote:
> I've been running production kernels in production with those changes
> and so far I haven't observed a single crash resulting from this.
> Furthermore, I believe that all the call sites of synproxy_build_ip
> should have the skb associated with a valid tcp socket, which must have
> originated from a particular namespace.
Please, always Cc: netfilter-devel@vger.kernel.org for patches that
modify netfilter code. Your change is buggy, we cannot assume skb->sk
set on packets that are being forwarded, we could have detected this
following this process.
Thanks.
next prev parent reply other threads:[~2016-03-24 20:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 14:27 [PATCH] netfilter: ipv4: fix NULL dereference Liping Zhang
2016-03-24 8:00 ` Nikolay Borisov
[not found] ` <54382a12.8a92.153a7ba19ff.Coremail.zlpwmdx@163.com>
2016-03-24 8:45 ` Nikolay Borisov
2016-03-24 20:16 ` Pablo Neira Ayuso [this message]
2016-03-24 20:22 ` Pablo Neira Ayuso
2016-03-25 6:38 ` Liping Zhang
2016-03-25 10:49 ` Pablo Neira Ayuso
2016-03-25 7:24 ` Liping Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160324201644.GB1561@salvia \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=kernel@kyup.com \
--cc=liping.zhang@spreadtrum.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=zlpwmdx@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).