From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Guruswamy Basavaiah <guru2018@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] iptables-translate: Initializing comment member in xt_xlate structure
Date: Tue, 29 Mar 2016 12:58:45 +0200 [thread overview]
Message-ID: <20160329105845.GA10458@salvia> (raw)
In-Reply-To: <20160328190436.GA19755@localhost.localdomain>
On Tue, Mar 29, 2016 at 12:34:36AM +0530, Guruswamy Basavaiah wrote:
> Initializing comment member in xt_xlate structure.
>
> Because of not initializing, when translating iptables command with multiple
> ip addresses, In the translated commands --comment field is getting added.
>
> Before fix:
> inbhdhcp21574:basavaia$>sudo ./iptables-translate -A INPUT --source "40.0.0.1, 30.0.0.1" --dest "20.0.0.1, 60.0.0.1" -j ACCEPT
> nft add rule ip filter INPUT ip saddr 40.0.0.1 ip daddr 20.0.0.1 counter accept
> add rule ip filter INPUT ip saddr 40.0.0.1 ip daddr 60.0.0.1 counter comment \" \" accept
> add rule ip filter INPUT ip saddr 30.0.0.1 ip daddr 20.0.0.1 counter comment \" \" accept
> add rule ip filter INPUT ip saddr 30.0.0.1 ip daddr 60.0.0.1 counter comment \" \" accept
Thanks, I already pushed something similar yesterday.
http://git.netfilter.org/iptables/commit/?id=c93850d1d78c7040709d78aee5514c5c5035c4ab
prev parent reply other threads:[~2016-03-29 10:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-28 19:04 [PATCH] iptables-translate: Initializing comment member in xt_xlate structure Guruswamy Basavaiah
2016-03-29 10:58 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160329105845.GA10458@salvia \
--to=pablo@netfilter.org \
--cc=guru2018@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).