From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 1/1] net: netfilter: Fix stack out of bounds when parsing TCP options
Date: Thu, 7 Apr 2016 18:43:11 +0200 [thread overview]
Message-ID: <20160407164311.GA2535@salvia> (raw)
In-Reply-To: <1459330475-2220-2-git-send-email-kadlec@blackhole.kfki.hu>
On Wed, Mar 30, 2016 at 11:34:35AM +0200, Jozsef Kadlecsik wrote:
> Baozeng Ding reported a KASAN stack out of bounds issue - it uncovered that
> the TCP option parsing routines in netfilter TCP connection tracking could
> read one byte out of the buffer of the TCP options. Therefore in the patch
> we check that the available data length is large enough to parse both TCP
> option code and size.
Applied, thanks Jozsef.
prev parent reply other threads:[~2016-04-07 16:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 9:34 [PATCH 0/1] netfilter TCP conntrack option parser fix Jozsef Kadlecsik
2016-03-30 9:34 ` [PATCH 1/1] net: netfilter: Fix stack out of bounds when parsing TCP options Jozsef Kadlecsik
2016-04-07 16:43 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160407164311.GA2535@salvia \
--to=pablo@netfilter.org \
--cc=kadlec@blackhole.kfki.hu \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).