netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Mart Frauenlob <mart.frauenlob@chello.at>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] conntrack-tools: Fix build for old automake.
Date: Thu, 7 Apr 2016 18:47:58 +0200	[thread overview]
Message-ID: <20160407164758.GA5353@salvia> (raw)
In-Reply-To: <1459762780-10255-2-git-send-email-mart.frauenlob@chello.at>

On Mon, Apr 04, 2016 at 11:39:40AM +0200, Mart Frauenlob wrote:
>  autoreconf fails with automake version smaller than 1.12,
>  because of undefined macro AM_PROG_AR.
>  So only expand it if it's actually defined.
> 
> Signed-off-by: Mart Frauenlob <mart.frauenlob@chello.at>
> ---
>  configure.ac |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index c541034..2c5913f 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -14,7 +14,7 @@ AC_SUBST([libdl_LIBS])
>  
>  AC_PROG_CC
>  AC_DISABLE_STATIC
> -AM_PROG_AR
> +m4_ifdef([AM_PROG_AR], [AM_PROG_AR]) dnl Workaround for Automake 1.11

How old is your old system? is it still a distro maintained version?

BTW, you can remove the comment, we can get to this information
through 'git annotate' these days.

Thanks.

  reply	other threads:[~2016-04-07 16:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-04  9:39 [PATCH v2] conntrack-tools: Fix build for old automake Mart Frauenlob
2016-04-04  9:39 ` [PATCH] " Mart Frauenlob
2016-04-07 16:47   ` Pablo Neira Ayuso [this message]
2016-04-07 17:33     ` Mart Frauenlob
2016-04-07 17:50       ` Pablo Neira Ayuso
2016-04-07 17:53         ` Mart Frauenlob
2016-04-08  6:40           ` Mart Frauenlob
2016-04-08  9:42             ` Pablo Neira Ayuso
  -- strict thread matches above, loose matches on Subject: below --
2016-04-04  9:29 Mart Frauenlob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160407164758.GA5353@salvia \
    --to=pablo@netfilter.org \
    --cc=mart.frauenlob@chello.at \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).