netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Mart Frauenlob <mart.frauenlob@chello.at>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 1/5] conntrack: add --proto to usage output.
Date: Fri, 8 Apr 2016 12:17:12 +0200	[thread overview]
Message-ID: <20160408101712.GA2142@salvia> (raw)
In-Reply-To: <1460053902-2200-2-git-send-email-mart.frauenlob@chello.at>

On Thu, Apr 07, 2016 at 08:31:38PM +0200, Mart Frauenlob wrote:
> 
> Signed-off-by: Mart Frauenlob <mart.frauenlob@chello.at>
> ---
>  src/conntrack.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/conntrack.c b/src/conntrack.c
> index dadbea5..162caa9 100644
> --- a/src/conntrack.c
> +++ b/src/conntrack.c
> @@ -551,7 +551,7 @@ static const char usage_parameters[] =
>  	"  -d, --orig-dst ip\t\tDestination address from original direction\n"
>  	"  -r, --reply-src ip\t\tSource addres from reply direction\n"
>  	"  -q, --reply-dst ip\t\tDestination address from reply direction\n"
> -	"  -p, --protonum proto\t\tLayer 4 Protocol, eg. 'tcp'\n"
> +	"  -p, --proto, --protonum proto\t\tLayer 4 Protocol, eg. 'tcp'\n"

This works too:

# conntrack --pr tcp -L
tcp      6 431998 ESTABLISHED src=10.123.10.20 dst=1.2.3.4
sport=47488 dport=80 src=1.2.3.4 dst=10.123.10.20 sport=80
dport=47488 [ASSURED] mark=0 use=1

Really, I wouldn't worry about this.

  reply	other threads:[~2016-04-08 10:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-07 18:31 [PATCH 0/5] conntrack: documentation updates Mart Frauenlob
2016-04-07 18:31 ` [PATCH 1/5] conntrack: add --proto to usage output Mart Frauenlob
2016-04-08 10:17   ` Pablo Neira Ayuso [this message]
2016-04-07 18:31 ` [PATCH 2/5] conntrack: man: add --protonum option Mart Frauenlob
2016-04-07 18:31 ` [PATCH 3/5] conntrack: show --src and --dst options in usage output Mart Frauenlob
2016-04-08 10:18   ` Pablo Neira Ayuso
2016-04-07 18:31 ` [PATCH 4/5] conntrack: man: add options --src and --dst Mart Frauenlob
2016-04-08 10:19   ` Pablo Neira Ayuso
2016-04-07 18:31 ` [PATCH 5/5] conntrack: man: Add description of tables dying and unconfirmed Mart Frauenlob
2016-04-08 10:19   ` Pablo Neira Ayuso
2016-04-08 10:27     ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160408101712.GA2142@salvia \
    --to=pablo@netfilter.org \
    --cc=mart.frauenlob@chello.at \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).