From: Florian Westphal <fw@strlen.de>
To: Phil Sutter <phil@nwl.cc>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
netfilter-devel@vger.kernel.org, Florian Westphal <fw@strlen.de>
Subject: Re: [PATCH] netfilter: ebtables: Fix extension lookup with identical name
Date: Tue, 12 Apr 2016 01:36:34 +0200 [thread overview]
Message-ID: <20160411233634.GA15916@breakpoint.cc> (raw)
In-Reply-To: <1460417474-8899-1-git-send-email-phil@nwl.cc>
Phil Sutter <phil@nwl.cc> wrote:
> If a requested extension exists as module and is not loaded,
> ebt_check_match() might accidentally use an NFPROTO_UNSPEC one with same
> name and fail.
>
> Reproduced with limit match: Given xt_limit and ebt_limit both built as
> module, the following would fail:
>
> modprobe xt_limit
> ebtables -I INPUT --limit 1/s -j ACCEPT
>
> The fix is to make ebt_check_match() distrust a found NFPROTO_UNSPEC
> extension and retry after requesting an appropriate module.
>
> Cc: Florian Westphal <fw@strlen.de>
Acked-by: Florian Westphal <fw@strlen.de>
Thanks for handling this.
next prev parent reply other threads:[~2016-04-11 23:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-11 23:31 [PATCH] netfilter: ebtables: Fix extension lookup with identical name Phil Sutter
2016-04-11 23:36 ` Florian Westphal [this message]
2016-04-12 23:17 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160411233634.GA15916@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).