From: Pablo Neira Ayuso <pablo@netfilter.org>
To: "Carlos Falgueras García" <carlosfg@riseup.net>
Cc: netfilter-devel@vger.kernel.org, kaber@trash.net
Subject: Re: [PATCH 1/4 v6] libnftnl: Implement new buffer of TLV objects
Date: Thu, 14 Apr 2016 01:55:40 +0200 [thread overview]
Message-ID: <20160413235540.GB4253@salvia> (raw)
In-Reply-To: <20160413231322.GA4253@salvia>
On Thu, Apr 14, 2016 at 01:13:22AM +0200, Pablo Neira Ayuso wrote:
> > +/* nftnl_udata_buf */
> > +struct nftnl_udata_buf *nftnl_udata_buf_alloc(uint32_t data_size);
> > +void nftnl_udata_buf_free(struct nftnl_udata_buf *buf);
> > +uint32_t nftnl_udata_buf_len(const struct nftnl_udata_buf *buf);
> > +uint32_t nftnl_udata_buf_size(const struct nftnl_udata_buf *buf);
>
> Do we need nftnl_udata_buf_size? If not, please remove this.
>
> We should only expose the interfaces that are strictly necessary.
Just manually removed this function myself here and applied this
patch.
prev parent reply other threads:[~2016-04-13 23:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-22 19:46 [PATCH 1/4 v6] libnftnl: Implement new buffer of TLV objects Carlos Falgueras García
2016-03-22 19:46 ` [PATCH 2/4 v6] libnftnl: rule: Change the "userdata" attribute to use new TLV buffer Carlos Falgueras García
2016-04-13 23:59 ` Pablo Neira Ayuso
2016-04-14 17:55 ` Carlos Falgueras García
2016-04-15 10:38 ` Pablo Neira Ayuso
2016-03-22 19:46 ` [PATCH 3/4 v6] libnftnl: test: Update test to check new nftnl_udata features of nftnl_rule Carlos Falgueras García
2016-04-14 0:00 ` Pablo Neira Ayuso
2016-03-22 19:46 ` [PATCH 4/4 v6] nftables: rule: Change the field "rule->comment" for an nftnl_udata_buf Carlos Falgueras García
2016-04-14 0:01 ` Pablo Neira Ayuso
2016-04-13 23:13 ` [PATCH 1/4 v6] libnftnl: Implement new buffer of TLV objects Pablo Neira Ayuso
2016-04-13 23:55 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160413235540.GB4253@salvia \
--to=pablo@netfilter.org \
--cc=carlosfg@riseup.net \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).