From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH v5 nf-next 4/4] netfilter: nftables: add connlabel set support
Date: Thu, 14 Apr 2016 12:05:27 +0200 [thread overview]
Message-ID: <20160414100527.GB3192@breakpoint.cc> (raw)
In-Reply-To: <20160414094835.GA2119@salvia>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> On Tue, Apr 12, 2016 at 06:14:26PM +0200, Florian Westphal wrote:
> > diff --git a/net/netfilter/nft_ct.c b/net/netfilter/nft_ct.c
> > index 25998fa..4ec1cea 100644
> > --- a/net/netfilter/nft_ct.c
> > +++ b/net/netfilter/nft_ct.c
> > @@ -29,6 +29,11 @@ struct nft_ct {
> > enum nft_registers dreg:8;
> > enum nft_registers sreg:8;
> > };
> > + union {
> > + u8 set_bit;
> > + } imm;
> > + unsigned int imm_len:8;
> > + struct nft_data immediate;
>
> Could you use select_ops() so we don't increase the size of nft_ct for
> other users?
Sure.
I'd split this into nft_ct (sreg/dreg)
and nft_ct_set_imm (set from immediate).
Does that sound okay?
next prev parent reply other threads:[~2016-04-14 10:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-12 16:14 [PATCH v5 nf-next 0/4] netfilter: nftables: add connlabel set support Florian Westphal
2016-04-12 16:14 ` [PATCH v5 nf-next 1/4] netfilter: connlabels: move helpers to xt_connlabel Florian Westphal
2016-04-12 16:14 ` [PATCH v5 nf-next 2/4] netfilter: labels: don't emit ct event if labels were not changed Florian Westphal
2016-04-12 16:14 ` [PATCH v5 nf-next 3/4] netfilter: connlabels: change nf_connlabels_get bit arg to 'highest used' Florian Westphal
2016-04-12 16:14 ` [PATCH v5 nf-next 4/4] netfilter: nftables: add connlabel set support Florian Westphal
2016-04-14 9:57 ` Pablo Neira Ayuso
2016-04-14 10:05 ` Florian Westphal [this message]
2016-04-14 10:08 ` Pablo Neira Ayuso
2016-04-14 11:26 ` Florian Westphal
2016-04-14 12:35 ` Pablo Neira Ayuso
2016-04-15 11:00 ` [PATCH v5 nf-next 0/4] " Pablo Neira Ayuso
2016-04-15 13:14 ` Florian Westphal
2016-04-18 18:39 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160414100527.GB3192@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).