From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Westphal Subject: Re: [PATCH nf-next] netfilter: conntrack: don't acquire lock during seq_printf Date: Thu, 14 Apr 2016 13:16:56 +0200 Message-ID: <20160414111656.GC3192@breakpoint.cc> References: <1460402069-22101-1-git-send-email-fw@strlen.de> <20160414094346.GA2056@salvia> <20160414100542.GA2644@salvia> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Florian Westphal , netfilter-devel@vger.kernel.org To: Pablo Neira Ayuso Return-path: Received: from Chamillionaire.breakpoint.cc ([80.244.247.6]:41738 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752595AbcDNLRE (ORCPT ); Thu, 14 Apr 2016 07:17:04 -0400 Content-Disposition: inline In-Reply-To: <20160414100542.GA2644@salvia> Sender: netfilter-devel-owner@vger.kernel.org List-ID: Pablo Neira Ayuso wrote: > > net/netfilter/nf_conntrack_proto_sctp.c | 8 +------- > > net/netfilter/nf_conntrack_proto_tcp.c | 8 +------- > > 2 files changed, 2 insertions(+), 14 deletions(-) > > > > diff --git a/net/netfilter/nf_conntrack_proto_sctp.c b/net/netfilter/nf_conntrack_proto_sctp.c > > index 9578a7c..1d7ab96 100644 > > --- a/net/netfilter/nf_conntrack_proto_sctp.c > > +++ b/net/netfilter/nf_conntrack_proto_sctp.c > > @@ -191,13 +191,7 @@ static void sctp_print_tuple(struct seq_file *s, > > /* Print out the private part of the conntrack. */ > > static void sctp_print_conntrack(struct seq_file *s, struct nf_conn *ct) > > { > > - enum sctp_conntrack state; > > - > > - spin_lock_bh(&ct->lock); > > - state = ct->proto.sctp.state; > > Don't we need at least READ_ONCE() here? Why? seq_printf(s, "%s ", sctp_conntrack_names[ct->proto.sctp.state]); I think thats fine, where do you see a problem?