From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [PATCH] netfilter: ctnetlink: add more #ifdef around unused code Date: Mon, 18 Apr 2016 20:16:59 +0200 Message-ID: <20160418181659.GA2427@salvia> References: <1460837916-1241019-1-git-send-email-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Patrick McHardy , Jozsef Kadlecsik , "David S. Miller" , Daniel Borkmann , Ken-ichirou MATSUZAWA , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Arnd Bergmann Return-path: Received: from mail.us.es ([193.147.175.20]:35758 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751563AbcDRSRH (ORCPT ); Mon, 18 Apr 2016 14:17:07 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 568BFC107F for ; Mon, 18 Apr 2016 20:17:03 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 45CCDFAB44 for ; Mon, 18 Apr 2016 20:17:03 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id D98369D104 for ; Mon, 18 Apr 2016 20:17:00 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1460837916-1241019-1-git-send-email-arnd@arndb.de> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Sat, Apr 16, 2016 at 10:17:43PM +0200, Arnd Bergmann wrote: > A recent patch removed many 'inline' annotations for static > functions in this file, which has caused warnings for functions > that are not used in a given configuration, in particular when > CONFIG_NF_CONNTRACK_EVENTS is disabled: > > nf_conntrack_netlink.c:572:15: 'ctnetlink_timestamp_size' defined but not used > nf_conntrack_netlink.c:546:15: 'ctnetlink_acct_size' defined but not used > nf_conntrack_netlink.c:339:12: 'ctnetlink_label_size' defined but not used Arnd, thanks for the fix. I'm planning to push this though: http://patchwork.ozlabs.org/patch/610820/ This is restoring the inlines for the size calculation functions, but I think that's ok. They are rather small and they're called from the event notification path (ie. packet path), so the compiler just place them out of the way when not needed and we calm down the gcc warning. Thanks!