From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH] evaluate: better error reporting in too long sets names
Date: Wed, 27 Apr 2016 19:14:19 +0200 [thread overview]
Message-ID: <20160427171419.GA7625@salvia> (raw)
In-Reply-To: <146115978018.25287.16460508385150502285.stgit@nfdev2.cica.es>
On Wed, Apr 20, 2016 at 03:43:00PM +0200, Arturo Borrero Gonzalez wrote:
> Currently, if we choose a set name larger than allowed, the error message is:
> Error: Could not process rule: Numerical result out of range
>
> Let's inform the user with a better error message.
>
> We can discuss later if length of set names should be increased, but I think
> this better error reporting is necessary right now to avoid headaches to users.
/* The max length of strings including NUL: set and type identifiers */
#define IPSET_MAXNAMELEN 32
I would like that we get the same length as ipset, this should make it
easier for people to migrate.
This would require a bit of work though since the interface name size
is limited by the register size. Not much a problem, but it would
require a bit of code adjustments from the kernel.
So let me postpone this userspace check.
next prev parent reply other threads:[~2016-04-27 17:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-20 13:43 [nft PATCH] evaluate: better error reporting in too long sets names Arturo Borrero Gonzalez
2016-04-27 17:14 ` Pablo Neira Ayuso [this message]
2016-04-27 17:36 ` Jozsef Kadlecsik
2016-04-27 17:37 ` Pablo Neira Ayuso
2016-04-28 7:42 ` Arturo Borrero Gonzalez
2016-05-04 6:26 ` Arturo Borrero Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160427171419.GA7625@salvia \
--to=pablo@netfilter.org \
--cc=arturo.borrero.glez@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).