From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Jarno Rajahalme <jarno@ovn.org>,
netfilter-devel@vger.kernel.org, kernel-janitors@vger.kernel.org,
dev@openvswitch.org, fw@strlen.de
Subject: Re: [PATCH] nf_nat_packet: Clear skb hash after modifying packet headers.
Date: Fri, 29 Apr 2016 11:12:12 +0200 [thread overview]
Message-ID: <20160429091212.GL17538@breakpoint.cc> (raw)
In-Reply-To: <20160429090959.GA7236@salvia>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> On Wed, Apr 20, 2016 at 02:31:10PM -0700, Jarno Rajahalme wrote:
> > Clear the skb hash when it does not reflect the actual header values
> > any more.
> >
> > Signed-off-by: Jarno Rajahalme <jarno@ovn.org>
> > ---
> > net/netfilter/nf_nat_core.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/net/netfilter/nf_nat_core.c b/net/netfilter/nf_nat_core.c
> > index 06a9f45..3c2302f 100644
> > --- a/net/netfilter/nf_nat_core.c
> > +++ b/net/netfilter/nf_nat_core.c
> > @@ -505,6 +505,7 @@ unsigned int nf_nat_packet(struct nf_conn *ct,
> > if (!l3proto->manip_pkt(skb, 0, l4proto, &target, mtype))
> > return NF_DROP;
> > }
> > + skb_clear_hash(skb);
> > return NF_ACCEPT;
> > }
>
> Cc'ing Florian.
>
> This seems to affect the new tracing infrastructure for nf_tables:
Right.
Jarno, what is your patch trying to fix?
next prev parent reply other threads:[~2016-04-29 9:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-20 21:31 [PATCH] nf_nat_packet: Clear skb hash after modifying packet headers Jarno Rajahalme
2016-04-29 9:09 ` Pablo Neira Ayuso
2016-04-29 9:12 ` Florian Westphal [this message]
[not found] ` <20160429091212.GL17538-E0PNVn5OA6ohrxcnuTQ+TQ@public.gmane.org>
2016-04-29 18:04 ` Jarno Rajahalme
2016-04-30 7:57 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160429091212.GL17538@breakpoint.cc \
--to=fw@strlen.de \
--cc=dev@openvswitch.org \
--cc=jarno@ovn.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).