From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org, a.hajda@samsung.com
Subject: Re: [PATCH nf-next] netfilter: fix IS_ERR_VALUE usage
Date: Fri, 29 Apr 2016 11:17:54 +0200 [thread overview]
Message-ID: <20160429091754.GN17538@breakpoint.cc> (raw)
In-Reply-To: <1461920038-6795-1-git-send-email-pablo@netfilter.org>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> This is a forward-ported original patch from Andrzej Hajda, he said:
>
> "IS_ERR_VALUE should be used only with unsigned long type.
> Otherwise it can work incorrectly. To achieve this function
> xt_percpu_counter_alloc is modified to return unsigned long,
> and its result is assigned to temporary variable to perform
> error checking, before assigning to .pcnt field.
>
> The patch follows conclusion from discussion on LKML [1][2].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2120927
> [2]: http://permalink.gmane.org/gmane.linux.kernel/2150581"
>
> Original patch from Andrzej is here:
>
> http://patchwork.ozlabs.org/patch/582970/
>
> This patch has clashed with input validation fixes for x_tables.
AFAICS this isn't a bug fix so I'm fine with this going into nf-next.
next prev parent reply other threads:[~2016-04-29 9:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 8:53 [PATCH nf-next] netfilter: fix IS_ERR_VALUE usage Pablo Neira Ayuso
2016-04-29 9:17 ` Florian Westphal [this message]
2016-04-29 9:30 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160429091754.GN17538@breakpoint.cc \
--to=fw@strlen.de \
--cc=a.hajda@samsung.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).