From: David Miller <davem@davemloft.net>
To: arnd@arndb.de
Cc: pablo@netfilter.org, kaber@trash.net, kadlec@blackhole.kfki.hu,
fw@strlen.de, daniel@iogearbox.net, sasha.levin@oracle.com,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] netfilter: conntrack: remove uninitialized shadow variable
Date: Tue, 10 May 2016 01:04:18 -0400 (EDT) [thread overview]
Message-ID: <20160510.010418.1148844422449581387.davem@davemloft.net> (raw)
In-Reply-To: <1462823254-3137116-1-git-send-email-arnd@arndb.de>
From: Arnd Bergmann <arnd@arndb.de>
Date: Mon, 9 May 2016 21:47:23 +0200
> A recent commit introduced an unconditional use of an uninitialized
> variable, as reported in this gcc warning:
>
> net/netfilter/nf_conntrack_core.c: In function '__nf_conntrack_confirm':
> net/netfilter/nf_conntrack_core.c:632:33: error: 'ctinfo' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> bytes = atomic64_read(&counter[CTINFO2DIR(ctinfo)].bytes);
> ^
> net/netfilter/nf_conntrack_core.c:628:26: note: 'ctinfo' was declared here
> enum ip_conntrack_info ctinfo;
>
> The problem is that a local variable shadows the function parameter.
> This removes the local variable, which looks like what Pablo originally
> intended.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 71d8c47fc653 ("netfilter: conntrack: introduce clash resolution on insertion race")
Applied.
prev parent reply other threads:[~2016-05-10 5:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-09 19:47 [PATCH] netfilter: conntrack: remove uninitialized shadow variable Arnd Bergmann
2016-05-09 20:01 ` Pablo Neira Ayuso
2016-05-09 20:12 ` Arnd Bergmann
2016-05-10 5:04 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160510.010418.1148844422449581387.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arnd@arndb.de \
--cc=coreteam@netfilter.org \
--cc=daniel@iogearbox.net \
--cc=fw@strlen.de \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=sasha.levin@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).